github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1588] [MERGED] fix gap in background color application resulting in flashing during transitions #2984

New Issue
Closed
opened 2025-11-26 23:26:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1588
Author: @mpbw2
Created: 10/15/2021
Status: ✅ Merged
Merged: 10/15/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-themegap

📝 Commits (1)

  • fe85a50 fix gap in theme application resulting in flashing during transitions

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 src/Android/MainActivity.cs (+1 -0)
📝 src/Android/Utilities/ThemeHelpers.cs (+4 -0)

📄 Description

There was a gap in the application of background color (Android only) when activities are first created, resulting in unpleasant transitions between screens when selecting non-item things (types, folders, collections). In addition due to the way our splash screen is implemented you could also see our logo during the gap, making the experience even less pleasant. This was previously covered by the app restarting on theme change, which is no longer the case.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1588 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/15/2021 **Status:** ✅ Merged **Merged:** 10/15/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-themegap` --- ### 📝 Commits (1) - [`fe85a50`](https://github.com/bitwarden/android/commit/fe85a506d27c5121275e4d3fe2329802853cdbfd) fix gap in theme application resulting in flashing during transitions ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+1 -0) 📝 `src/Android/Utilities/ThemeHelpers.cs` (+4 -0) </details> ### 📄 Description There was a gap in the application of background color (Android only) when activities are first created, resulting in unpleasant transitions between screens when selecting non-item things (types, folders, collections). In addition due to the way our splash screen is implemented you could also see our logo during the gap, making the experience even less pleasant. This was previously covered by the app restarting on theme change, which is no longer the case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2984
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?