[PR #1586] [MERGED] Fix app crash when 'show password' clicked on empty field #2982

Closed
opened 2025-11-26 23:26:44 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1586
Author: @jlf0dev
Created: 10/15/2021
Status: Merged
Merged: 10/15/2021
Merged by: @jlf0dev

Base: masterHead: bug/view-password-null


📝 Commits (1)

  • 7bde7ab check password for null before setting cursor position

📊 Changes

3 files changed (+5 additions, -4 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+2 -1)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+1 -1)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+2 -2)

📄 Description

Check password for null before setting cursor position

closes #1578


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1586 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/15/2021 **Status:** ✅ Merged **Merged:** 10/15/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/view-password-null` --- ### 📝 Commits (1) - [`7bde7ab`](https://github.com/bitwarden/android/commit/7bde7aba7376f50ef9297ce9b8e5ccff8de5c494) check password for null before setting cursor position ### 📊 Changes **3 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+2 -1) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+2 -2) </details> ### 📄 Description Check password for null before setting cursor position closes #1578 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:44 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2982