github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2982] [MERGED] [PM-5907] Fix for incorrect TOTP white text color on label when using light theme on iOS #110970

New Issue
Closed
opened 2026-06-06 07:20:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 07:20:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2982
Author: @dinisvieira
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @dinisvieira

Base: feature/maui-migration ← Head: feature/PM-5907-incorrect-text-color-light-theme

📝 Commits (2)

  • 4d78f49 PM-5907 workaround for incorrect textcolor when programmatically changing text on Entry
  • 7db3bf6 Update src/Core/Pages/Vault/CipherAddEditPage.xaml.cs

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/Core/Pages/Vault/CipherAddEditPage.xaml.cs (+8 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix for incorrect TOTP white text color on label when using light theme on iOS.
This fix is a workaround for the MAUI Issue https://github.com/dotnet/maui/pull/20100

Code changes

  • CipherAddEditPage.xaml.cs: Set the TextColor to null and back to the correct color whenever we try to programatically change the entry text. Doing this avoids the bug.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2982 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migration` ← **Head:** `feature/PM-5907-incorrect-text-color-light-theme` --- ### 📝 Commits (2) - [`4d78f49`](https://github.com/bitwarden/android/commit/4d78f4965249e3eac5f619ce137f1ce5c77501d6) PM-5907 workaround for incorrect textcolor when programmatically changing text on Entry - [`7db3bf6`](https://github.com/bitwarden/android/commit/7db3bf6cb2bfa089a10425a60309aecf67df9316) Update src/Core/Pages/Vault/CipherAddEditPage.xaml.cs ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Vault/CipherAddEditPage.xaml.cs` (+8 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix for incorrect TOTP white text color on label when using light theme on iOS. This fix is a workaround for the MAUI Issue https://github.com/dotnet/maui/pull/20100 ## Code changes * **CipherAddEditPage.xaml.cs:** Set the TextColor to null and back to the correct color whenever we try to programatically change the entry text. Doing this avoids the bug. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 07:20:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#110970
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?