github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1575] [MERGED] Fix for Android 5.x crash caused by new switch styling #2974

New Issue
Closed
opened 2025-11-26 23:26:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:38 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1575
Author: @mpbw2
Created: 10/13/2021
Status: ✅ Merged
Merged: 10/13/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-android5-switchtint

📝 Commits (1)

  • 7017499 Fix for Android 5.x crash caused by new switch styling

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 src/Android/Renderers/CustomSwitchRenderer.cs (+7 -0)

📄 Description

Android 5.x Switch widget doesn't support ThumbTintList, and using SwitchCompat is yielding poor results on every version after 5.x. We'll let 5.x to do its own thing here (see screenshot). It's not fabulous, but it's better than the alternative.

This will be picked to rc.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1575 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/13/2021 **Status:** ✅ Merged **Merged:** 10/13/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-android5-switchtint` --- ### 📝 Commits (1) - [`7017499`](https://github.com/bitwarden/android/commit/7017499d50a309335aa70c8b99aab14a1217267c) Fix for Android 5.x crash caused by new switch styling ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Renderers/CustomSwitchRenderer.cs` (+7 -0) </details> ### 📄 Description Android 5.x `Switch` widget doesn't support `ThumbTintList`, and using `SwitchCompat` is yielding poor results on every version after 5.x. We'll let 5.x to do its own thing here (see screenshot). It's not fabulous, but it's better than the alternative. This will be picked to `rc`. ![image](https://user-images.githubusercontent.com/59324545/137159555-b0685f81-c16d-4fb6-9743-00df2c53dce8.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2974