github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2974] [MERGED] [PM-5902] Fix Account Switcher can't be dismissed when tapping outside of it #104129

New Issue
Closed
opened 2026-06-03 06:14:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-03 06:14:22 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2974
Author: @dinisvieira
Created: 2/1/2024
Status: ✅ Merged
Merged: 2/1/2024
Merged by: @dinisvieira

Base: feature/maui-migration ← Head: feature/pm-5902-account-switcher-cant-be-dismissed-tapping-outside

📝 Commits (1)

  • 94c94ea PM-5902 fix for account switcher not dismissing when tapping outside

📊 Changes

1 file changed (+8 additions, -5 deletions)

View changed files

📝 src/Core/Controls/AccountSwitchingOverlay/AccountSwitchingOverlayView.xaml (+8 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Account Switcher can't be dismissed by tapping in the empty space below it like we could with the Xamarin Forms app.
This is caused because FillAndExpand works differently in MAUI and will not "expand to fill" the entire screen space with the BoxView that we had before for detecting and dismissing the Account Switcher.

Code changes

  • AccountSwitchingOverlayView.xaml: Replace StackLayout with a Grid and set RowDefinitions. Setting "*" for the BoxView will ensure it "fills" the entire screen and therefore will detect the tap event that triggers the dismiss of the Account Switcher.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2974 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/1/2024 **Status:** ✅ Merged **Merged:** 2/1/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migration` ← **Head:** `feature/pm-5902-account-switcher-cant-be-dismissed-tapping-outside` --- ### 📝 Commits (1) - [`94c94ea`](https://github.com/bitwarden/android/commit/94c94ea6dac638afc433699f41eb4a4337191313) PM-5902 fix for account switcher not dismissing when tapping outside ### 📊 Changes **1 file changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Controls/AccountSwitchingOverlay/AccountSwitchingOverlayView.xaml` (+8 -5) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Account Switcher can't be dismissed by tapping in the empty space below it like we could with the Xamarin Forms app. This is caused because `FillAndExpand` works differently in MAUI and will not "expand to fill" the entire screen space with the BoxView that we had before for detecting and dismissing the Account Switcher. ## Code changes * **AccountSwitchingOverlayView.xaml:** Replace `StackLayout` with a Grid and set `RowDefinitions`. Setting "*" for the `BoxView `will ensure it "fills" the entire screen and therefore will detect the tap event that triggers the dismiss of the Account Switcher. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-03 06:14:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#104129