github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1555] [MERGED] Exclude deleted items from folder counts #2960

New Issue
Closed
opened 2025-11-26 23:26:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:27 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1555
Author: @jlf0dev
Created: 10/1/2021
Status: ✅ Merged
Merged: 10/4/2021
Merged by: @jlf0dev

Base: master ← Head: bug/nested-item-count

📝 Commits (1)

  • 074143e Exclude deleted items from folder counts

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+5 -0)

📄 Description

Prevents grouped pages from counting deleted items in the folder/collection counts. We were including these deleted items when doing type, folder, and collection counts on grouped pages (except the main page which had code to prevent it).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1555 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/1/2021 **Status:** ✅ Merged **Merged:** 10/4/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/nested-item-count` --- ### 📝 Commits (1) - [`074143e`](https://github.com/bitwarden/android/commit/074143eb416d8abf8bc1effc44096ca18e15998a) Exclude deleted items from folder counts ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+5 -0) </details> ### 📄 Description Prevents grouped pages from counting deleted items in the folder/collection counts. We were including these deleted items when doing type, folder, and collection counts on grouped pages (except the main page which had code to prevent it). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2960