github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1426] [MERGED] Fix selecting ciphers in search not working #2882

New Issue
Closed
opened 2025-11-26 23:25:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1426
Author: @Hinton
Created: 6/11/2021
Status: ✅ Merged
Merged: 6/11/2021
Merged by: @Hinton

Base: master ← Head: hotfix/select

📝 Commits (1)

  • e9af3de Fix selecting ciphers in search not working

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 src/App/Pages/Send/SendsPage.xaml.cs (+3 -2)
📝 src/App/Pages/Vault/CiphersPage.xaml.cs (+2 -1)

📄 Description

Objective

It seems https://github.com/bitwarden/mobile/pull/1374 broke selecting ciphers and sends when searching. When looking at the other pages which implements the same logic I noticed we forgot to add FirstOrDefault().

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1426 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 6/11/2021 **Status:** ✅ Merged **Merged:** 6/11/2021 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `hotfix/select` --- ### 📝 Commits (1) - [`e9af3de`](https://github.com/bitwarden/android/commit/e9af3deba14eccf3d97c9ab5d0dca3370f4e55b9) Fix selecting ciphers in search not working ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendsPage.xaml.cs` (+3 -2) 📝 `src/App/Pages/Vault/CiphersPage.xaml.cs` (+2 -1) </details> ### 📄 Description ## Objective It seems https://github.com/bitwarden/mobile/pull/1374 broke selecting ciphers and sends when searching. When looking at the other pages which implements the same logic I noticed we forgot to add `FirstOrDefault()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?