github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1416] [MERGED] Fixes for password reprompt #2876

New Issue
Closed
opened 2025-11-26 23:25:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1416
Author: @Hinton
Created: 5/31/2021
Status: ✅ Merged
Merged: 6/10/2021
Merged by: @Hinton

Base: master ← Head: hotfix/password-reprompt

📝 Commits (6)

  • f2d57fd Disable invalid password warning when clickinc cancel
  • aab6cac Add password prompt in overflow menus on iOS
  • 03416fb Add password prompt during autofill
  • a53fd17 Improve password check
  • 501112b Merge branch 'master' of github.com:bitwarden/mobile into hotfix/password-reprompt
  • eab65ff Remove variable from merge conflict

📊 Changes

7 files changed (+90 additions, -18 deletions)

View changed files

📝 src/App/Pages/Vault/ViewPage.xaml.cs (+6 -0)
📝 src/App/Services/MobilePlatformUtilsService.cs (+5 -0)
📝 src/App/Utilities/AppHelpers.cs (+4 -1)
📝 src/Core/Constants.cs (+2 -0)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+31 -3)
📝 src/iOS.Autofill/LockPasswordViewController.cs (+1 -0)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+41 -14)

📄 Description

Objective

Resolves some scenarios where the master password prompt didn't work.

For autofill it has two scenarios:

  • Locked: Since we don't have access to the decrypted item, we don't know if it needs MP prompt, therefore we first unlock using whatever method is available. If the MP was not used, we prompt for it using a dialog after unlocking.
  • Not locked: If the item requires prompt, we display a customized lock screen prompting for the password.

Code Changes

  • src/App/Pages/Vault/ViewPage.xaml.cs: Add password prompt for "more" menu on iOS.
  • src/App/Services/MobilePlatformUtilsService.cs: Remove "wrong password" dialog when clicking cancel.
  • src/App/Utilities/AppHelpers.cs: Add password prompt for edit button.
  • src/iOS.Autofill/CredentialProviderViewController.cs: Add password prompt during autofill.
  • src/iOS.Core/Controllers/LockPasswordViewController.cs: Display a customized lock screen when items is protected, and set a flag when authenticated using password.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1416 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 5/31/2021 **Status:** ✅ Merged **Merged:** 6/10/2021 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `hotfix/password-reprompt` --- ### 📝 Commits (6) - [`f2d57fd`](https://github.com/bitwarden/android/commit/f2d57fd3e498cf9102de45041556ee309cd72c73) Disable invalid password warning when clickinc cancel - [`aab6cac`](https://github.com/bitwarden/android/commit/aab6cacdd9027b24c31f43f4927e32ab4237aa02) Add password prompt in overflow menus on iOS - [`03416fb`](https://github.com/bitwarden/android/commit/03416fba7be20ec5f0a78f13d783f0ad24aea4ed) Add password prompt during autofill - [`a53fd17`](https://github.com/bitwarden/android/commit/a53fd17e1e29f6fa3c70969b60c56c4f4627d649) Improve password check - [`501112b`](https://github.com/bitwarden/android/commit/501112b60a66009340fa1cd09ee417ebf1062aff) Merge branch 'master' of github.com:bitwarden/mobile into hotfix/password-reprompt - [`eab65ff`](https://github.com/bitwarden/android/commit/eab65ffbda727f73333789f36495034696d53331) Remove variable from merge conflict ### 📊 Changes **7 files changed** (+90 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/ViewPage.xaml.cs` (+6 -0) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+5 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+4 -1) 📝 `src/Core/Constants.cs` (+2 -0) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+31 -3) 📝 `src/iOS.Autofill/LockPasswordViewController.cs` (+1 -0) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+41 -14) </details> ### 📄 Description ## Objective Resolves some scenarios where the master password prompt didn't work. For autofill it has two scenarios: - **Locked:** Since we don't have access to the decrypted item, we don't know if it needs MP prompt, therefore we first unlock using whatever method is available. If the MP was not used, we prompt for it using a dialog after unlocking. - **Not locked:** If the item requires prompt, we display a customized lock screen prompting for the password. ### Code Changes - **src/App/Pages/Vault/ViewPage.xaml.cs**: Add password prompt for "more" menu on iOS. - **src/App/Services/MobilePlatformUtilsService.cs**: Remove "wrong password" dialog when clicking cancel. - **src/App/Utilities/AppHelpers.cs**: Add password prompt for edit button. - **src/iOS.Autofill/CredentialProviderViewController.cs**: Add password prompt during autofill. - **src/iOS.Core/Controllers/LockPasswordViewController.cs**: Display a customized lock screen when items is protected, and set a flag when authenticated using password. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?