github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2876] [MERGED] [PM-4896] Fix null reference exception on the region when setting env urls #23236

New Issue
Closed
opened 2026-04-16 23:22:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:22:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2876
Author: @fedemkr
Created: 11/21/2023
Status: ✅ Merged
Merged: 12/1/2023
Merged by: @fedemkr

Base: master ← Head: PM-4896-fix-null-region-on-environment-urls-set

📝 Commits (6)

  • 760336d PM-4896 Fix null reference exception on the region
  • 7371d92 PM-4896 Updated dotnet version to set up in build workflow
  • 7f8626a PM-4896 Add NET 3.1.x and NET 7.0.x to Android build
  • 90204e7 PM-4896 Reversed to NET 3.1.x Android build
  • 2aa435c Merge branch 'master' into PM-4896-fix-null-region-on-environment-urls-set
  • cf3973b PM-4896 Removed changes on build.yml for net version name

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Services/EnvironmentService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix NRE on the region when setting the environment urls

Code changes

  • EnvironmentService: Added null check for region, if so set the region as the default US one.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2876 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 11/21/2023 **Status:** ✅ Merged **Merged:** 12/1/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-4896-fix-null-region-on-environment-urls-set` --- ### 📝 Commits (6) - [`760336d`](https://github.com/bitwarden/android/commit/760336d05edde4e9fccdd147b0971e494116eb5f) PM-4896 Fix null reference exception on the region - [`7371d92`](https://github.com/bitwarden/android/commit/7371d9295102c901da775631eba2cc3caf86a211) PM-4896 Updated dotnet version to set up in build workflow - [`7f8626a`](https://github.com/bitwarden/android/commit/7f8626a5310ab3b8780b1f9016085b6a3ff32487) PM-4896 Add NET 3.1.x and NET 7.0.x to Android build - [`90204e7`](https://github.com/bitwarden/android/commit/90204e7b93833478f58cf47a1b03bbe3b7dda933) PM-4896 Reversed to NET 3.1.x Android build - [`2aa435c`](https://github.com/bitwarden/android/commit/2aa435c7ea76c0c9f278837afc3574e49c63340c) Merge branch 'master' into PM-4896-fix-null-region-on-environment-urls-set - [`cf3973b`](https://github.com/bitwarden/android/commit/cf3973b12d28c0eaec2110b122e74e18ab591be7) PM-4896 Removed changes on build.yml for net version name ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/EnvironmentService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix NRE on the region when setting the environment urls ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **EnvironmentService:** Added null check for region, if so set the region as the default US one. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:22:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?