github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1015] [MERGED] Allow only non-deleted creds to be added to autofill #28718

New Issue
Closed
opened 2026-04-18 12:50:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 12:50:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1015
Author: @MattTheDev
Created: 7/16/2020
Status: ✅ Merged
Merged: 7/16/2020
Merged by: @MattTheDev

Base: master ← Head: prevent-trashed-from-autofill

📝 Commits (1)

  • eaabc88 Allow only non-deleted creds to be added to autofill

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/iOS.Core/Utilities/ASHelpers.cs (+1 -1)

📄 Description

Objective

Prevent trashed credentials from being made available in iOS autofill. Didn't appear to be an issue on Android.

Code Changes

src/iOS.Core/Utilities/ASHelpers.cs - Was going to create a new service method that returned untrashed/undeleted credentials, but this seemed like the path of least resistance.

This will close #1014

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1015 **Author:** [@MattTheDev](https://github.com/MattTheDev) **Created:** 7/16/2020 **Status:** ✅ Merged **Merged:** 7/16/2020 **Merged by:** [@MattTheDev](https://github.com/MattTheDev) **Base:** `master` ← **Head:** `prevent-trashed-from-autofill` --- ### 📝 Commits (1) - [`eaabc88`](https://github.com/bitwarden/android/commit/eaabc88ba1de23b8e0869433381ed87a0c4a6633) Allow only non-deleted creds to be added to autofill ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+1 -1) </details> ### 📄 Description ## Objective Prevent trashed credentials from being made available in iOS autofill. Didn't appear to be an issue on Android. ## Code Changes **src/iOS.Core/Utilities/ASHelpers.cs** - Was going to create a new service method that returned untrashed/undeleted credentials, but this seemed like the path of least resistance. This will close #1014 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 12:50:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#28718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?