mirror of
https://github.com/bitwarden/android.git
synced 2026-05-11 02:15:43 -05:00
[Android 6] Stable version offers "Unlock with Fingerprint", Beta doesn't. #1014
Closed
opened 2025-11-26 22:36:49 -06:00 by GiteaMirror
·
6 comments
No Branch/Tag Specified
main
sdlc/sdk-update
renovate/lock-file-maintenance
renovate/sonarqube
renovate/fastlane-2.x
crowdin-pull
cron-sync-privileged-browsers/60-sync
agalles/fdroid-only
remove-retrofit-dependency
release/hotfix-v2026.4.1-bwpm
beta-for-qa
target-sdk-37
PM-33982/build-device-screen
new-item-types/PM-32806_passport
new-item-types/PM-32808_drivers-license
BWA-99/show-next-totp
BWA-99/add-preview-next-totp-code-setting
renovate/glidecompose
sync-min-sdk
release/2026.4-rc51
fix/security-sast-22741894-bvwj
related-origin-passkey-creation
release/2026.4-rc50
platform/android-breaking-change-detection
innovation-sprint-2026-send-folder
release/2026.3-rc49
PM-34193-vault-lockout
android-collections
llm/add-resolving-sdk-updates-skill
QA-1523/sanity-test-saucelabs
release/2026.3-rc48
PM-26577-app-links-support
PM-26896-autofill-fix
release/2026.2-rc47
pr-6572
release/2026.2-rc46
release/2026.1-rc45
PM-30644/added-logs-for-debug
PM-30644/quicktile-nav-not-showing-migration
minor-gradle-updates
release/2026.1-rc42
release/2026.1-rc44
release/2026.1-rc43
PM-28834/set-landscape-on-horizonos-devices
PM-28468/validate-and-navigate-to-vault-migration
PM-20026/force-ltr-passwords-and-codes
release/2025.12-rc41
cmcg/testCoverage
PM-29014/talkback-support-for-passwords
release/2025.12-rc40
BRE-1305/publish_test
accept-user-certs
autofill-permissions
release/2025.11-rc39
PM-22479/check-all-certificates-validate-asset-links
release/2025.10-rc38
agalles/android-latest
retro-agent
PM-27001/skip-account-selection-only-one-exists-cxp
release/2025.10-rc37
agalles/test-1118
release/2025.10-rc36
PM-20593-token-refresh
QA-1126b/adding-native-sanity-test
release/2025.9-rc35
pm-25933/sdk-update-password
release/2025.9-rc34
release/2025.8-rc33
agalles/20250821-release
debug-release-issues
pm-24249-allow-automated-prs-for-sdk-updates
release/2025.8-rc32
release/WORKFLOW-TEST-2025.8-rc28
agalles/20250807release
release/2025.07-rc25
release/hotfix-v2025.7.0-bwa
pm-23311/export-vault-policy-bypass
release/2025.07-rc24
authenticator-pm-sync-flags-issue
release/hotfix-v2025.6.0-bwpm
release/2025.06-rc21
agalles/automate-android-fastlane-patch
release/2025.05-rc20
release/2025.04-rc19
languages/basque
release/2025.03-rc19
update-readme
qrcode/feature
innovation/archive/pm-19153-archive-items
qrcode/2-ui-fields
qrcode/1-page
hold-on-biometric-prompt-alternative
release-notes-process
release/2025.02-rc16
bwa-monorepo
PM-8223/new-device-verification-ux-improvements
pm-18451/exempt-from-policies
test-bwa
release/2025.01-rc15
release/2025.01-rc14
release/2024.12-rc13
pm-16670/sync-leave-notice
821
PM-16695/backport-lean-more-new-device-verification
release/hotfix-v2024.11.7
release/2024.11-rc1
pm-11304/collection-add-item-button
PM-14241/disabling-logs-app-crash
poc/offline-editing
new-version-calc
pm-11649/expired-link-services
pm-6702/add-feature-flag
pm-6702/email-verification-feature
pm-9933/marketing-copy-update
pm-6702/registration-flows
update-templates
pm-6701/email-verification-selfhost-registration
v2026.4.1-bwa
v2026.4.1-bwpm
v2026.4.0-bwa
v2026.4.0-bwpm
v2026.3.1-bwa
v2026.3.1-bwpm
v2026.3.0-bwpm
v2026.3.0-bwa
v2026.2.1-bwpm
v2026.2.1-bwa
v2026.2.0-bwpm
v2026.2.0-bwa
v2026.1.1-bwa
v2026.1.1-bwpm
temp-test
v2026.1.0-bwpm
v2026.1.0-bwa
v2025.12.1-bwa
v2025.12.1-bwpm
v2025.12.0-bwa
v2025.12.0-bwpm
v2025.11.1-bwpm
v2025.11.1-bwa
v2025.11.0-bwpm
v2025.11.0-bwa
v2025.10.1-bwa
v2025.10.1-bwpm
v2025.10.0-bwa
v2025.10.0-bwpm
v2025.9.1-bwa
v2025.9.1-bwpm
v2025.9.0-bwa
v2025.9.0-bwpm
v2025.8.1-bwa
v2025.8.1-bwpm
v2025.8.0-bwa
v2025.8.0-bwpm
v2025.7.2-bwa
v2025.7.2-bwpm
v2025.7.1-bwa
v2025.7.1-bwpm
v2025.7.0-bwa
v2025.7.0-bwpm
v2025.6.1-bwpm
v2025.6.0-bwa
v2025.6.0-bwpm
v2025.1.0-bwa
v2025.5.0-bwa
v2025.5.0-bwpm
v2025.5.999
2025.4.0
v2025.4.0
untagged-4731eaadac73f3dfbbb8
v2025.3.0
v2025.2.0
untagged-815a165c5d70ffe75bc7
v2025.1.2
v2025.1.1
v2025.1.0
v2024.12.0
untagged-5a76b6392a4c8998c63a
v2024.11.7
v2024.11.6
v2024.11.5
v2024.11.4
v2024.11.3
v2024.11.2
v2024.11.1
v2024.11.0
v2024.10.2
v2024.10.1
v2024.10.0
v2024.9.0
v2024.8.1
v2024.8.0
v2024.7.3
v2024.7.2
v2024.7.1
v2024.7.0
v2024.6.1
v2024.6.0
v2024.5.1
v2024.4.1
v2024.4.2
v2024.4.0
v2024.3.3
v2024.3.1
v2024.3.0
v2024.2.1
v2024.2.0
v2024.1.1
v2024.1.0
v2023.12.0
v2023.10.0
v2023.9.2
maui-single-project-android
v2023.9.1
v2023.9.0
v2023.8.0
v2023.7.0
v2023.5.0
v2023.4.0
v2023.3.2
v2023.3.1
v2023.3.0
v2023.2.0
v2023.1.0
v2022.11.0
v2022.10.0
v2022.9.1
v2022.9.0
v2022.8.0
v2022.6.2
v2022.6.1
v2022.6.0
v2022.05.0
v2.18.0
v2.17.0
v2.16.4
v2.16.3
v2.16.2
v2.16.1
v2.15.0
v2.14.2
v2.14.1
v2.14.0
v2.13.0
v2.12.0
v2.11.3
v2.11.2
v2.11.1
v2.11.0
v2.10.0
v2.9.1
v2.9.0
v2.8.2
v2.8.1
v2.8.0
v2.7.2
v2.7.0
v2.6.1
v2.6.0
v2.5.6
v.2.5.5
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.1
v2.3.0
v2.2.8
v2.2.7
v2.2.6
v2.2.2
v2.2.1
v2.2.0
v2.1.2
v2.1.0
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.22.1
v1.22.0
v1.21.0
v1.20.0
v1.19.0
v1.18.1
v1.18.0
v1.17.0
v1.16.0
v1.15.2
v1.15.1
v1.15.0
v1.14.4
v1.14.1
v1.14.0
v1.13.0
v1.12.2
v1.12.1
v1.12.0
v1.11.1
v1.11.0
v1.10.0
v1.9.0
v1.8.1
v1.8.0
v1.7.0
v1.6.5
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.4
v1.4.3
v1.4.0
v1.3.0
v1.2.1
v1.2.0
v1.1.0
v1.0.0
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/android#1014
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @contribucious on GitHub (May 17, 2020).
Originally assigned to: @mpbw2 on GitHub.
Describe the Bug
In the stable version (
2.3.1 (2257)), under Android 6.0 Marshmallow (Samsung Galaxy Tab S 10.5" / Android 6.0.1), Bitwarden offers me the option "Unlock with Fingerprint" in the settings.In the beta version (since at least
2.3.1 (2353)), Bitwarden does not offer it anymore on my tablet. Despite the presence of a fingerprint sensor built into this tablet.ℹ️ As soon as I return to the stable version, this option reappears (and is fully functional).
Screenshots — Stable version,
2.3.1 (2257)View me ... 👈
Screenshots — Beta version,
2.3.1 (2353)View me ... 👈
Remarks
If during the transition from the stable version to the beta, the option "Unlock with Fingerprint" was on "Enabled", it will still be visible in the settings and marked as "Enabled", but:
USE FINGERPRINT TO UNLOCKbutton above theLOG OUTbutton to do it manually will do no action when tapped;USE FINGERPRINT TO UNLOCKbutton on the lock screen too, from now on).Probable cause
This commit from this PR which updates the package "Plugin.Fingerprint" from version 1.4.9 to v2. However, according to this README, Android 6.0 is still listed as supported (updated last month).
Interesting links about this plugin:
1 I recently tested to compile the latest version of Bitwarden with the "Plugin.Fingerprint" package in version 2.1.0 and 2.0.0 (with these two, Bitwarden also successfully compiles, but the problem remains ...).
Resolution
You will have to see on your side if it's an upstream bug (requiring a report on the repo of @smstuebe) or not. :octocat: I am available for additional tests if necessary. 👍
@mpbw2 commented on GitHub (Jun 7, 2020):
@contribucious I'm unable to reproduce this on the hardware I have at my disposal so I'm attempting to use an emulator. On a fresh 6.0 emulator image, the fingerprint unlock option is missing from Bitwarden settings. As soon as I go into Android security settings and add a fingerprint, the option becomes available in Bitwarden. Now I'm guessing you already have a fingerprint or two setup on your device, but just out of curiosity - can you try adding another one, then restart Bitwarden and see if the option is available?
@mpbw2 commented on GitHub (Jun 8, 2020):
@contribucious Can you see if this build fixes the problem:
[link removed - build in beta]
@mpbw2 commented on GitHub (Jun 8, 2020):
@contribucious Sorry to spam you :) We pushed an update to beta (give it an hour or two) so you can just test from there. Thanks!
@contribucious commented on GitHub (Jun 8, 2020):
TL;DR
Explanation: Samsung Pass SDK support removed from "Plugin.Fingerprint" package in version 2.0.0 of the latter (see 1 and 2 + there).
Percentage of certainty of the cause: 99%.
➡️ Android 6.0 Marshmallow used in my case ✔️ ...
↪️ ... but special case — [official] upgrade.
(cc @kspearrin)
Hello @mportune-bw,
I directly tested your apk (to go faster) and no improvement, despite switching to the password system in Android temporarily (to be able to delete all my three fingerprints) then reactivation (to reintroduce one), followed by a check in Bitwarden (freshly launched).
But I clearly think I have found the cause now. 👍
↪️ And it relates to Samsung specifically (hence the non-reproducibility in your Android emulator).
Introduction
I had seen it right apparently: the problem seems to be related to the transition to v2 of the "Plugin.Fingerprint" package ... which removes support for the Samsung Pass SDK for fingerprint management. See this commit and this one of the same name + the diff between 1.4.9 and 2.0.0 here.
👉 The problem
Basically, we tend to think that the native support for fingerprints in Android (FingerprintManager — although now deprecated in favor of BiometricPrompt) requires just one condition: Android 6.0 Marshmallow or higher.
BUT some (if not all) Samsung devices that were created before Marshmallow, like my Samsung Galaxy Tab S 10.5" tablet from 2014, despite an official upgrade to Marshmallow (6.0.1) from KitKat (4.4.2), still only support the Samsung Pass SDK for fingerprint management. Explanations here but several sources confirm this.
That explains a lot
This now also explains why, while I have no problem on my Android 9 smartphone, lots of apps on my tablet do not have the Fingerprint option in the settings (or have this option grayed out with the phrase "Not supported on your device", this is the case with LastPass for example), while other apps have the option and the corresponding functional support (these are the ones that support the Samsung Pass SDK, quite simply).
Conclusion
I will have to live with the PIN system only from now on my tablet therefore for Bitwarden, since @smstuebe wanted to remove the support for the Samsung Pass SDK (known to be bugged it seems, by the way).
Sorry for the length.
@smstuebe Hello. Could you confirm that my reasoning above is correct?
Do you think your phrase "replaced custom dialog and Samsung pass with BiometricPrompt" in the changelog of your v2 explains all this? Thank you in advance.
@mpbw2 commented on GitHub (Jun 8, 2020):
Thanks for testing @contribucious - and your conclusion makes perfect sense. However several of our play store reviews regarding recent broken fingerprint support are using devices that should have access to FingerprintManager & BiometricPrompt (unless a decision was made to exclude those official SDKs in their updated system images for some reason - lack of drivers maybe?)
Galaxy S9 (Android 10)
Galaxy Note 8 (Android 9)
Galaxy S7 (Android 8)
UMIDIGI X (Android 9)
vivo 1910 (Android 9)
@contribucious commented on GitHub (Jun 8, 2020):
Hmm ... That seems to be another problem however. ☺️
But if @smstuebe goes through here, he might be able to light that up too. 👍