github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1260] [MERGED] UX tweaks for Send #2811

New Issue
Closed
opened 2025-11-26 23:24:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1260
Author: @mpbw2
Created: 2/11/2021
Status: ✅ Merged
Merged: 2/11/2021
Merged by: @mpbw2

Base: master ← Head: tweaks-send

📝 Commits (5)

  • 532fd38 additional help text
  • 5ea0b19 replace send type picker with segmented control
  • 473728c formatting
  • 3435da5 added note about rider issue
  • a754838 additional design tweaks

📊 Changes

14 files changed (+202 additions, -95 deletions)

View changed files

📝 src/App/Pages/Accounts/TwoFactorPage.xaml (+3 -3)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+15 -15)
📝 src/App/Pages/Send/SendAddEditPage.xaml (+115 -33)
📝 src/App/Pages/Send/SendAddEditPage.xaml.cs (+17 -2)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+10 -30)
📝 src/App/Pages/Settings/AutofillServicesPage.xaml (+4 -4)
📝 src/App/Pages/Settings/OptionsPage.xaml (+3 -3)
📝 src/App/Pages/Settings/SyncPage.xaml (+1 -1)
📝 src/App/Pages/Vault/AddEditPage.xaml (+2 -2)
📝 src/App/Pages/Vault/CollectionsPage.xaml (+1 -1)
📝 src/App/Pages/Vault/SharePage.xaml (+1 -1)
📝 src/App/Resources/AppResources.Designer.cs (+18 -0)
📝 src/App/Resources/AppResources.resx (+10 -0)
📝 src/App/Styles/Base.xaml (+2 -0)

📄 Description

Additional adjustments based on web PR 822:

  • Additional help text
  • Replace Send type picker with segmented control (radio buttons can be iffy on mobile)

("copy on send" was already implemented as "share on send")

Screen Shot 2021-02-11 at 12 26 21 PM
Screen Shot 2021-02-11 at 12 26 42 PM
Screen Shot 2021-02-11 at 12 27 08 PM
Screen Shot 2021-02-11 at 12 27 44 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1260 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/11/2021 **Status:** ✅ Merged **Merged:** 2/11/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `tweaks-send` --- ### 📝 Commits (5) - [`532fd38`](https://github.com/bitwarden/android/commit/532fd3800b4313800b4da9b61ec8998ef6529f7c) additional help text - [`5ea0b19`](https://github.com/bitwarden/android/commit/5ea0b197253f75f5352d0ebff6095af2dc892440) replace send type picker with segmented control - [`473728c`](https://github.com/bitwarden/android/commit/473728c05e33f054af01a589eb2e244eb17cb75e) formatting - [`3435da5`](https://github.com/bitwarden/android/commit/3435da549d76a7f921d18522382d74c1005e058f) added note about rider issue - [`a754838`](https://github.com/bitwarden/android/commit/a754838315fdd29eecdd65b59ccafcea2d67771e) additional design tweaks ### 📊 Changes **14 files changed** (+202 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml` (+3 -3) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+15 -15) 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+115 -33) 📝 `src/App/Pages/Send/SendAddEditPage.xaml.cs` (+17 -2) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+10 -30) 📝 `src/App/Pages/Settings/AutofillServicesPage.xaml` (+4 -4) 📝 `src/App/Pages/Settings/OptionsPage.xaml` (+3 -3) 📝 `src/App/Pages/Settings/SyncPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+2 -2) 📝 `src/App/Pages/Vault/CollectionsPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/SharePage.xaml` (+1 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+18 -0) 📝 `src/App/Resources/AppResources.resx` (+10 -0) 📝 `src/App/Styles/Base.xaml` (+2 -0) </details> ### 📄 Description Additional adjustments based on [web PR 822](https://github.com/bitwarden/web/pull/822): - Additional help text - Replace Send type picker with segmented control (radio buttons can be iffy on mobile) ("copy on send" was already implemented as "share on send") ![Screen Shot 2021-02-11 at 12 26 21 PM](https://user-images.githubusercontent.com/59324545/107674619-2305a000-6c65-11eb-9139-dc2695dfdba1.png) ![Screen Shot 2021-02-11 at 12 26 42 PM](https://user-images.githubusercontent.com/59324545/107674632-24cf6380-6c65-11eb-825f-7c3c996d8fbf.png) ![Screen Shot 2021-02-11 at 12 27 08 PM](https://user-images.githubusercontent.com/59324545/107674637-26992700-6c65-11eb-8ec3-9acd380860b4.png) ![Screen Shot 2021-02-11 at 12 27 44 PM](https://user-images.githubusercontent.com/59324545/107674644-2862ea80-6c65-11eb-8d45-3947b5fd355d.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2811
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?