github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1230] [MERGED] Add passphrase generator to iOS Extensions #2801

New Issue
Closed
opened 2025-11-26 23:24:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1230
Author: @eliykat
Created: 1/21/2021
Status: ✅ Merged
Merged: 1/25/2021
Merged by: @eliykat

Base: master ← Head: passphrase-generator-in-extension

📝 Commits (5)

  • 641f539 Add passphrase generator options to iOS extension
  • e011b02 Set custom indentation on WordSeparator control
  • f1f1a79 Set correct RowsInSection for passphrase controls
  • abcb711 Fix RowsInSection for password controls
  • 2319ff7 Add avoid ambiguous characters control

📊 Changes

3 files changed (+134 additions, -28 deletions)

View changed files

📝 src/iOS.Core/Controllers/PasswordGeneratorViewController.cs (+114 -24)
📝 src/iOS.Core/Views/FormEntryTableViewCell.cs (+17 -4)
📝 src/iOS.Core/Views/PickerTableViewCell.cs (+3 -0)

📄 Description

Objective

Fix #620: the iOS autofill and extension password generator does not give the user the options to generate a passphrase.

Edit: I also noticed that the "Avoid ambiguous characters" switch was missing when generating a password, so I added that control as well.

Code changes

  • add required controls and logic to iOS.Core/Controllers/PasswordGeneratorViewController.cs.
  • add some event handlers to FormEntryTableViewCell and PickerTableViewCell so that we can regenerate the password when their value changes
  • let developer specify a custom indentation for FormEntryTableViewCell objects - this is required to line it up with the other controls (not sure if there is a better way of doing this)

Screenshots

New passphrase controls:

Added "Avoid ambiguous characters" control (note that this now pushes the "Option defaults are set..." text off-screen on an iPhone 12 - not sure if that's worth worrying about):

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1230 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 1/21/2021 **Status:** ✅ Merged **Merged:** 1/25/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `passphrase-generator-in-extension` --- ### 📝 Commits (5) - [`641f539`](https://github.com/bitwarden/android/commit/641f53974600a23335729eb6ced260ca87bd9e7c) Add passphrase generator options to iOS extension - [`e011b02`](https://github.com/bitwarden/android/commit/e011b02b412f279ee83800fd5b6765020d0748b6) Set custom indentation on WordSeparator control - [`f1f1a79`](https://github.com/bitwarden/android/commit/f1f1a79c80db7d14db56d72d56629d3e722336d5) Set correct RowsInSection for passphrase controls - [`abcb711`](https://github.com/bitwarden/android/commit/abcb7115e7da2b94c2c08666fcfee3ced97b2ef6) Fix RowsInSection for password controls - [`2319ff7`](https://github.com/bitwarden/android/commit/2319ff7ff8149ca7b1bfd78eba8d52c075a9ded7) Add avoid ambiguous characters control ### 📊 Changes **3 files changed** (+134 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/PasswordGeneratorViewController.cs` (+114 -24) 📝 `src/iOS.Core/Views/FormEntryTableViewCell.cs` (+17 -4) 📝 `src/iOS.Core/Views/PickerTableViewCell.cs` (+3 -0) </details> ### 📄 Description ## Objective Fix #620: the iOS autofill and extension password generator does not give the user the options to generate a passphrase. Edit: I also noticed that the "Avoid ambiguous characters" switch was missing when generating a password, so I added that control as well. ## Code changes - add required controls and logic to `iOS.Core/Controllers/PasswordGeneratorViewController.cs`. - add some event handlers to `FormEntryTableViewCell` and `PickerTableViewCell` so that we can regenerate the password when their value changes - let developer specify a custom indentation for `FormEntryTableViewCell` objects - this is required to line it up with the other controls (not sure if there is a better way of doing this) ## Screenshots New passphrase controls: <img src="https://user-images.githubusercontent.com/31796059/105260837-3bd8e380-5bda-11eb-8158-cbaadaa88cf8.png" width="50%"> Added "Avoid ambiguous characters" control (note that this now pushes the "Option defaults are set..." text off-screen on an iPhone 12 - not sure if that's worth worrying about): <img src="https://user-images.githubusercontent.com/31796059/105269488-bfe19a00-5bdf-11eb-8720-ed3231fd1fad.png" width="50%"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?