github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1200] [MERGED] Do not export items that have been deleted #2790

New Issue
Closed
opened 2025-11-26 23:24:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1200
Author: @MGibson1
Created: 12/29/2020
Status: ✅ Merged
Merged: 12/29/2020
Merged by: @MGibson1

Base: master ← Head: do-not-export-trashed-items

📝 Commits (1)

  • 6e0d09f Do not export items that have been deleted

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 src/Core/Services/ExportService.cs (+3 -2)

📄 Description

Overview

Do not export items that have been trashed. Related to this community request.

It seems like in the future we will want to optionally export trashed items with a flag showing they are trashed. However, this aligns closer to expected behavior for now.

Files Changed

  • ExportService.ce: Filter all ciphers to include only those without DeletedDates

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1200 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 12/29/2020 **Status:** ✅ Merged **Merged:** 12/29/2020 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `do-not-export-trashed-items` --- ### 📝 Commits (1) - [`6e0d09f`](https://github.com/bitwarden/android/commit/6e0d09f5334f20c95cab560d5ab2163185d54271) Do not export items that have been deleted ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/ExportService.cs` (+3 -2) </details> ### 📄 Description # Overview Do not export items that have been trashed. Related to [this community request](https://community.bitwarden.com/t/deleted-password-shows-up-in-vault-export/13246/14). It seems like in the future we will want to optionally export trashed items with a flag showing they are trashed. However, this aligns closer to expected behavior for now. # Files Changed * **ExportService.ce**: Filter all ciphers to include only those without `DeletedDate`s --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?