github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1091] [MERGED] [SSO] New user provision flow #2739

New Issue
Closed
opened 2025-11-26 23:23:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1091
Author: @vincentsalucci
Created: 9/24/2020
Status: ✅ Merged
Merged: 10/13/2020
Merged by: @vincentsalucci

Base: master ← Head: m-user-provision

📝 Commits (2)

  • cf0ad81 Initial commit for new user provision flow
  • 8c559d2 Merge branch 'master' into m-user-provision

📊 Changes

5 files changed (+11 additions, -5 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginSsoPage.xaml.cs (+2 -2)
📝 src/App/Pages/Accounts/SetPasswordPage.xaml.cs (+2 -1)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+2 -0)
📝 src/App/Pages/Accounts/TwoFactorPage.xaml.cs (+4 -2)
📝 src/Core/Models/Request/SetPasswordRequest.cs (+1 -0)

📄 Description

Objective

Currently, when a new bitwarden/org user is created, they are given a status of accepted. This can create issues for organizations trying to confirm the same user (which can't happen until they've set their master password). To alleviate the issue, change new user's orgUser status to invited until after they've set a master password. Pass through the necessary information for the 2fa and set-password components.

Code Changes

  • LoginSsoPage.xaml.cs: Passed already existing _vm.orgIdentifier into the constructor for both the 2fa and SetPassword pages.
  • SetPasswordPage.xaml.cs: Added orgIdentifier to the constructor. Saved parameter value to the underlying view model.
  • SetPasswordPageViewModel.cs: Created OrgIdentifier property and assigned value to the SetPasswordRequest OrgIdentifier field.
  • TwoFactorPage.xaml.cs: Added orgIdentifier to the constructor and created member variable for passing along the result to the SetPasswordPage
  • SetPasswordRequest.cs: Added OrgIdentifier string to the request object.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1091 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 9/24/2020 **Status:** ✅ Merged **Merged:** 10/13/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-user-provision` --- ### 📝 Commits (2) - [`cf0ad81`](https://github.com/bitwarden/android/commit/cf0ad811f776a30d096256826ac163514b172bdb) Initial commit for new user provision flow - [`8c559d2`](https://github.com/bitwarden/android/commit/8c559d2e0211823fcb3814387ad58beef19107cb) Merge branch 'master' into m-user-provision ### 📊 Changes **5 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginSsoPage.xaml.cs` (+2 -2) 📝 `src/App/Pages/Accounts/SetPasswordPage.xaml.cs` (+2 -1) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+2 -0) 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml.cs` (+4 -2) 📝 `src/Core/Models/Request/SetPasswordRequest.cs` (+1 -0) </details> ### 📄 Description ## Objective > Currently, when a new bitwarden/org user is created, they are given a status of `accepted`. This can create issues for organizations trying to `confirm` the same user (which can't happen until they've set their master password). To alleviate the issue, change new user's `orgUser` status to `invited` until after they've set a master password. Pass through the necessary information for the `2fa` and `set-password` components. ## Code Changes - **LoginSsoPage.xaml.cs**: Passed already existing `_vm.orgIdentifier` into the constructor for both the `2fa` and `SetPassword` pages. - **SetPasswordPage.xaml.cs**: Added `orgIdentifier` to the constructor. Saved parameter value to the underlying view model. - **SetPasswordPageViewModel.cs**: Created `OrgIdentifier` property and assigned value to the `SetPasswordRequest` `OrgIdentifier` field. - **TwoFactorPage.xaml.cs**: Added `orgIdentifier` to the constructor and created member variable for passing along the result to the `SetPasswordPage` - **SetPasswordRequest.cs**: Added `OrgIdentifier` string to the request object. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?