github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #964] [MERGED] Biometrics cleanup #2687

New Issue
Closed
opened 2025-11-26 23:22:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/964
Author: @mpbw2
Created: 6/8/2020
Status: ✅ Merged
Merged: 6/8/2020
Merged by: @kspearrin

Base: master ← Head: biometrics

📝 Commits (1)

📊 Changes

18 files changed (+117 additions, -257 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+2 -104)
📝 src/App/Abstractions/IDeviceActionService.cs (+0 -3)
📝 src/App/App.xaml.cs (+8 -9)
📝 src/App/Pages/Accounts/LockPage.xaml (+2 -2)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+10 -10)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+22 -28)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+4 -8)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+19 -23)
📝 src/App/Resources/AppResources.Designer.cs (+0 -1)
📝 src/App/Resources/AppResources.resx (+1 -1)
📝 src/App/Services/MobilePlatformUtilsService.cs (+28 -24)
📝 src/Core/Abstractions/IVaultTimeoutService.cs (+2 -2)
📝 src/Core/Constants.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+1 -1)
📝 src/Core/Services/CryptoService.cs (+4 -4)
📝 src/Core/Services/VaultTimeoutService.cs (+8 -8)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+5 -5)
📝 src/iOS.Core/Services/DeviceActionService.cs (+0 -23)

📄 Description

  • Refactored code to use "biometric" terminology so it doesn't conflict with "fingerprint" (phrase)
  • Removed native biometric code for Android 10 as the plugin handles it now
  • Changed phrasing on Android to "Biometric Verification" as it's the system's responsibility to identify the method used. Even though the Biometric API was added in Android 10, the BiometricPrompt API was added in 9 to cover for vendors introducing other methods (face, iris). The system can do a better job of prompting the user than we can (see screenshots)
  • iOS code remains mostly untouched

I'm hoping by removing any custom code we'll fix the fingerprint oddities we're seeing right now, as well as some labeling oddities for users running Anrdoid 9.

Screen Shot 2020-06-07 at 10 21 52 PM

device-2020-06-07-222337

device-2020-06-07-222608

Screen Shot 2020-06-07 at 10 29 52 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/964 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/8/2020 **Status:** ✅ Merged **Merged:** 6/8/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `biometrics` --- ### 📝 Commits (1) - [`0e71522`](https://github.com/bitwarden/android/commit/0e71522dffc089f0948add783c1ee29b61e34a53) biometrics cleanup ### 📊 Changes **18 files changed** (+117 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+2 -104) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+0 -3) 📝 `src/App/App.xaml.cs` (+8 -9) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+2 -2) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+10 -10) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+22 -28) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+4 -8) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+19 -23) 📝 `src/App/Resources/AppResources.Designer.cs` (+0 -1) 📝 `src/App/Resources/AppResources.resx` (+1 -1) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+28 -24) 📝 `src/Core/Abstractions/IVaultTimeoutService.cs` (+2 -2) 📝 `src/Core/Constants.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+1 -1) 📝 `src/Core/Services/CryptoService.cs` (+4 -4) 📝 `src/Core/Services/VaultTimeoutService.cs` (+8 -8) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+5 -5) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+0 -23) </details> ### 📄 Description - Refactored code to use "biometric" terminology so it doesn't conflict with "fingerprint" (phrase) - Removed native biometric code for Android 10 as the plugin handles it now - Changed phrasing on Android to "Biometric Verification" as it's the system's responsibility to identify the method used. Even though the Biometric API was added in Android 10, the BiometricPrompt API was added in 9 to cover for vendors introducing other methods (face, iris). The system can do a better job of prompting the user than we can (see screenshots) - iOS code remains mostly untouched I'm hoping by removing any custom code we'll fix the fingerprint oddities we're seeing right now, as well as some labeling oddities for users running Anrdoid 9. ![Screen Shot 2020-06-07 at 10 21 52 PM](https://user-images.githubusercontent.com/59324545/83988280-cbae7380-a910-11ea-8630-807b987fbe73.png) ![device-2020-06-07-222337](https://user-images.githubusercontent.com/59324545/83988286-cf41fa80-a910-11ea-86ec-30389a45b9e8.png) ![device-2020-06-07-222608](https://user-images.githubusercontent.com/59324545/83988292-d36e1800-a910-11ea-971a-4ea833128dd0.png) ![Screen Shot 2020-06-07 at 10 29 52 PM](https://user-images.githubusercontent.com/59324545/83988297-d832cc00-a910-11ea-978b-3484d98a57b0.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?