github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2687] [MERGED] [PM-3385] Fix Master Password reprompt item level (TDE) #23116

New Issue
Closed
opened 2026-04-16 23:16:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:16:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2687
Author: @fedemkr
Created: 8/14/2023
Status: ✅ Merged
Merged: 8/14/2023
Merged by: @fedemkr

Base: feature/pm-1029-tde-login ← Head: vault/pm-3385/fix-tde-mp-reprompt-item-level

📝 Commits (1)

  • 2f42f4a PM-3385 Fix MP reprompt item level when no MP hash is stored like logging in with TDE. Also refactor code to be more maintainable

📊 Changes

10 files changed (+52 additions, -45 deletions)

View changed files

📝 src/App/Abstractions/IPasswordRepromptService.cs (+2 -1)
📝 src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (+1 -1)
📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+2 -2)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+2 -2)
📝 src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs (+1 -1)
📝 src/App/Services/MobilePasswordRepromptService.cs (+12 -1)
📝 src/App/Utilities/AppHelpers.cs (+29 -34)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+1 -1)
📝 src/iOS.Autofill/Utilities/AutofillHelpers.cs (+1 -1)
📝 src/iOS.Extension/LoginListViewController.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix MP reprompt to be bypassed when no master hash is stored, like with TDE.

Code changes

  • MobilePasswordRepromptService.cs: Added check of master password hash to bypass MP reprompt and also added the Cipher reprompt type check inside to be more maintainable.
  • Others: Adapted code to new method

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2687 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/14/2023 **Status:** ✅ Merged **Merged:** 8/14/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/pm-1029-tde-login` ← **Head:** `vault/pm-3385/fix-tde-mp-reprompt-item-level` --- ### 📝 Commits (1) - [`2f42f4a`](https://github.com/bitwarden/android/commit/2f42f4a1efb0cc7c8db5b7d5af0d0c13bc402468) PM-3385 Fix MP reprompt item level when no MP hash is stored like logging in with TDE. Also refactor code to be more maintainable ### 📊 Changes **10 files changed** (+52 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Abstractions/IPasswordRepromptService.cs` (+2 -1) 📝 `src/App/Pages/Vault/AutofillCiphersPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+2 -2) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+2 -2) 📝 `src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs` (+1 -1) 📝 `src/App/Services/MobilePasswordRepromptService.cs` (+12 -1) 📝 `src/App/Utilities/AppHelpers.cs` (+29 -34) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+1 -1) 📝 `src/iOS.Autofill/Utilities/AutofillHelpers.cs` (+1 -1) 📝 `src/iOS.Extension/LoginListViewController.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix MP reprompt to be bypassed when no master hash is stored, like with TDE. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **MobilePasswordRepromptService.cs:** Added check of master password hash to bypass MP reprompt and also added the Cipher reprompt type check inside to be more maintainable. * **Others:** Adapted code to new method ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:16:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?