github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 08:33:59 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #741] [MERGED] Password generator policy enforcement #2565

New Issue
Closed
opened 2025-11-26 23:21:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/741
Author: @mpbw2
Created: 2/27/2020
Status: ✅ Merged
Merged: 2/28/2020
Merged by: @mpbw2

Base: master ← Head: feature-policy-generator

📝 Commits (4)

  • 21b7bc3 Password generator policy enforcement
  • 8494c6a Formatting
  • 197747e Changed to simple cast (double unboxing for int64/long)
  • 3987221 Added ui indication of active policy on password generator page and fixed issue with switch enable logic

📊 Changes

9 files changed (+231 additions, -12 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPage.xaml (+27 -0)
📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+31 -3)
📝 src/App/Resources/AppResources.Designer.cs (+6 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Abstractions/IPasswordGenerationService.cs (+3 -3)
➕ src/Core/Models/Domain/PasswordGeneratorPolicyOptions.cs (+13 -0)
📝 src/Core/Services/PasswordGenerationService.cs (+146 -4)
📝 src/Core/Utilities/ServiceContainer.cs (+1 -1)
📝 src/iOS.Core/Controllers/PasswordGeneratorViewController.cs (+1 -1)

📄 Description

Enforcement of password generator policies. Handling of UI widgets on generator screen could use some polish but I'd like a review for this so far. (I don't see a way to comment on a review request, just a PR)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/741 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/27/2020 **Status:** ✅ Merged **Merged:** 2/28/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-policy-generator` --- ### 📝 Commits (4) - [`21b7bc3`](https://github.com/bitwarden/android/commit/21b7bc363b64687472a1cf4ec55d6ac53e1cdc4f) Password generator policy enforcement - [`8494c6a`](https://github.com/bitwarden/android/commit/8494c6a8b580632a2ff7b9848f50aff98dfd5ab9) Formatting - [`197747e`](https://github.com/bitwarden/android/commit/197747e690278943a17a84f7add39c8e08fc662e) Changed to simple cast (double unboxing for int64/long) - [`3987221`](https://github.com/bitwarden/android/commit/398722144d25208bb20729cbfdc3e857cca56fad) Added ui indication of active policy on password generator page and fixed issue with switch enable logic ### 📊 Changes **9 files changed** (+231 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+27 -0) 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+31 -3) 📝 `src/App/Resources/AppResources.Designer.cs` (+6 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Abstractions/IPasswordGenerationService.cs` (+3 -3) ➕ `src/Core/Models/Domain/PasswordGeneratorPolicyOptions.cs` (+13 -0) 📝 `src/Core/Services/PasswordGenerationService.cs` (+146 -4) 📝 `src/Core/Utilities/ServiceContainer.cs` (+1 -1) 📝 `src/iOS.Core/Controllers/PasswordGeneratorViewController.cs` (+1 -1) </details> ### 📄 Description Enforcement of password generator policies. Handling of UI widgets on generator screen could use some polish but I'd like a review for this so far. (I don't see a way to comment on a review request, just a PR) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?