github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #725] [MERGED] Migrate EnvironmentUrls to pref storage #2557

New Issue
Closed
opened 2025-11-26 23:21:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/725
Author: @kspearrin
Created: 2/10/2020
Status: ✅ Merged
Merged: 2/10/2020
Merged by: @kspearrin

Base: master ← Head: pref-migration

📝 Commits (1)

  • 622338a Migrate EnvironmentUrlsKey to pref storage

📊 Changes

2 files changed (+27 additions, -4 deletions)

View changed files

📝 src/App/Services/MobileStorageService.cs (+25 -3)
📝 src/App/Services/PreferencesStorageService.cs (+2 -1)

📄 Description

Currently, we store environment URLs in our LiteDB JSON database. Enterprise customers have expressed a desire to pre-configure the environment URL of the app for their employees using app installation tools like https://www.appconfig.org/. These tools can generally only pre-configure app values that are stored in NSUserDefaults (iOS) or SharedPreferences (Android). See https://www.appconfig.org/www/appconfig-content/uploads/2015/08/ImplementingAppConfigwithXamarin.pdf

To support this, we need to move environment URLs to be stored in our PreferencesStorageService. Existing users with configured environment URLs need to have their values migrated from LiteDbStorage to PreferencesStorageService.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/725 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 2/10/2020 **Status:** ✅ Merged **Merged:** 2/10/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `pref-migration` --- ### 📝 Commits (1) - [`622338a`](https://github.com/bitwarden/android/commit/622338a9a8cfb7d056b31274f9fb1492652d2b2a) Migrate EnvironmentUrlsKey to pref storage ### 📊 Changes **2 files changed** (+27 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Services/MobileStorageService.cs` (+25 -3) 📝 `src/App/Services/PreferencesStorageService.cs` (+2 -1) </details> ### 📄 Description Currently, we store environment URLs in our LiteDB JSON database. Enterprise customers have expressed a desire to pre-configure the environment URL of the app for their employees using app installation tools like https://www.appconfig.org/. These tools can generally only pre-configure app values that are stored in `NSUserDefaults` (iOS) or `SharedPreferences` (Android). See https://www.appconfig.org/www/appconfig-content/uploads/2015/08/ImplementingAppConfigwithXamarin.pdf To support this, we need to move environment URLs to be stored in our `PreferencesStorageService`. Existing users with configured environment URLs need to have their values migrated from `LiteDbStorage` to `PreferencesStorageService`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?