github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2020] [CLOSED] [PS-1227] About information not available when logged out #16049

New Issue
Closed
opened 2026-04-15 02:02:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:02:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2020
Author: @deividt
Created: 8/1/2022
Status: ❌ Closed

Base: main ← Head: dg/feature/about-information-not-available-when-logged-out

📝 Commits (1)

  • c493a54 Added "About" and "Help and Feedback" buttons to EnvironmentPage

📊 Changes

4 files changed (+69 additions, -22 deletions)

View changed files

📝 src/App/Pages/Accounts/EnvironmentPage.xaml (+22 -0)
📝 src/App/Pages/Accounts/EnvironmentPageViewModel.cs (+13 -0)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+2 -22)
📝 src/App/Utilities/AppHelpers.cs (+32 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the #2010 issue. It adds the "About" and "Help and Feedback" buttons to the settings pages when the user is logged out. Allowing to check the app version as well as copying it to the clipboard. In addition to that the user has an easy access to the Bitwarden help page.

Important:
The "Help and Feedback" button is not necessary to fix the issue, but I thought it would be important to add it since I didn't find it when the user is logged out too. What do you think?

Code changes

  • EnvironmentPage.xaml: Added the "About" and "Help and feedback" buttons in a new block called "Other" at the end of the EnvironmentPage. I followed the same style of the SettingsPage.
  • EnvironmentPageViewModel.cs: Added the commands that will trigger the actions of the buttons added in the EnvironmentPage.
  • SettingsPageViewModel.cs: Removed the code that triggers the button "About". Its code was moved to the AppHelpers class.
  • AppHelpers.cs: Added the "ShowAppVersionAsync" function, which will be used to show the app version at any place of the app. Such as: SettingsPage and EnvironmentPage.

Screenshots

Screenshot_1659319906

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2020 **Author:** [@deividt](https://github.com/deividt) **Created:** 8/1/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dg/feature/about-information-not-available-when-logged-out` --- ### 📝 Commits (1) - [`c493a54`](https://github.com/bitwarden/android/commit/c493a5417f368aa91dbe2008826e16998aef1713) Added "About" and "Help and Feedback" buttons to EnvironmentPage ### 📊 Changes **4 files changed** (+69 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/EnvironmentPage.xaml` (+22 -0) 📝 `src/App/Pages/Accounts/EnvironmentPageViewModel.cs` (+13 -0) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+2 -22) 📝 `src/App/Utilities/AppHelpers.cs` (+32 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective This PR fixes the #2010 issue. It adds the "About" and "Help and Feedback" buttons to the settings pages when the user is logged out. Allowing to check the app version as well as copying it to the clipboard. In addition to that the user has an easy access to the Bitwarden help page. **Important**: The "Help and Feedback" button is not necessary to fix the issue, but I thought it would be important to add it since I didn't find it when the user is logged out too. What do you think? ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **EnvironmentPage.xaml:** Added the "About" and "Help and feedback" buttons in a new block called "Other" at the end of the EnvironmentPage. I followed the same style of the SettingsPage. * **EnvironmentPageViewModel.cs:** Added the commands that will trigger the actions of the buttons added in the EnvironmentPage. * **SettingsPageViewModel.cs:** Removed the code that triggers the button "About". Its code was moved to the AppHelpers class. * **AppHelpers.cs:** Added the "ShowAppVersionAsync" function, which will be used to show the app version at any place of the app. Such as: SettingsPage and EnvironmentPage. ## Screenshots ![Screenshot_1659319906](https://user-images.githubusercontent.com/4616241/182062395-13f80d1d-d03f-4313-bf24-998f53c3567f.png) ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:02:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?