github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #7024] [CLOSED] 🍒 PM-38513: Bug: Policy manager bug fix #114110

New Issue
Closed
opened 2026-06-06 13:53:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-06 13:53:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7024
Author: @david-livefront
Created: 6/5/2026
Status: ❌ Closed

Base: main ← Head: PM-38513-policy-manager-bug-fix-rc

📝 Commits (3)

  • ee4b982 🍒 [PM-38364] fix: Multiply subscription line-item cost by quantity (#7013)
  • d359093 🍒 PM-38587: Feat: Add accessibility service disclaimer at startup (#7021)
  • 0cfba5e PM-38513: Do not emit policies before we have recieved them

📊 Changes

14 files changed (+419 additions, -29 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt (+32 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+53 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/billing/repository/util/BitwardenSubscriptionResponseJsonExtensions.kt (+27 -17)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+11 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+15 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt (+9 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+10 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+14 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt (+50 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/billing/repository/util/BitwardenSubscriptionResponseJsonExtensionsTest.kt (+122 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt (+36 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt (+15 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+24 -0)
📝 ui/src/main/res/values/strings.xml (+1 -0)

📄 Description

🎟️ Tracking

🍒 Cherry-pick

PM-38513

📔 Objective

This PR fixes a bug in the PolicyManager where we would emit policies before we had received them.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7024 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/5/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-38513-policy-manager-bug-fix-rc` --- ### 📝 Commits (3) - [`ee4b982`](https://github.com/bitwarden/android/commit/ee4b9823d1a6bd142522504eae1c7ebe086d71b3) 🍒 [PM-38364] fix: Multiply subscription line-item cost by quantity (#7013) - [`d359093`](https://github.com/bitwarden/android/commit/d3590935b02cd5a07ba4c9cac7601a0eb27cc394) 🍒 PM-38587: Feat: Add accessibility service disclaimer at startup (#7021) - [`0cfba5e`](https://github.com/bitwarden/android/commit/0cfba5ed9c1626132ad206256fde3e644f42e189) PM-38513: Do not emit policies before we have recieved them ### 📊 Changes **14 files changed** (+419 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt` (+32 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+53 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/billing/repository/util/BitwardenSubscriptionResponseJsonExtensions.kt` (+27 -17) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+11 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+15 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt` (+9 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+10 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+14 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt` (+50 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/billing/repository/util/BitwardenSubscriptionResponseJsonExtensionsTest.kt` (+122 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt` (+36 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt` (+15 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+24 -0) 📝 `ui/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking 🍒 Cherry-pick [PM-38513](https://bitwarden.atlassian.net/browse/PM-38513) ## 📔 Objective This PR fixes a bug in the `PolicyManager` where we would emit policies before we had received them. [PM-38513]: https://bitwarden.atlassian.net/browse/PM-38513?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-06 13:53:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#114110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?