bump version and fix readme

Fix black navigation bar on none Google ROMs.

README.md

@@ -8,7 +8,7 @@
 
 The Bitwarden mobile application is written in C# with Xamarin Android, Xamarin iOS, and Xamarin Forms.
 
-<img src="https://raw.githubusercontent.com/bitwarden/brand/master/screenshots/mobile-android.png" alt="" width="300" height="533" /> <img src="https://raw.githubusercontent.com/bitwarden/brand/master/screenshots/mobile-ios.png" alt="" width="300" height="533" />
+<img src="https://raw.githubusercontent.com/bitwarden/brand/master/screenshots/mobile-android-myvault.png" alt="" width="300" height="533" /> <img src="https://raw.githubusercontent.com/bitwarden/brand/master/screenshots/mobile-ios.png" alt="" width="300" height="533" />
 
 # Build/Run
 

appveyor.yml

@@ -71,7 +71,7 @@ build_script:
       mkdir dist
       cp CNAME ./dist
       cd store
-      chmod 600 fdroid/config.py keystore.jks
+      chmod 600 fdroid/config.py fdroid/keystore.jks
       mkdir -p temp/fdroid
       TEMP_DIR="$APPVEYOR_BUILD_FOLDER/store/temp/fdroid"
       cd fdroid

src/Android/MainApplication.cs

@@ -2,6 +2,8 @@
 using System.IO;
 using System.Threading.Tasks;
 using Android.App;
+using Android.Content;
+using Android.OS;
 using Android.Runtime;
 using Bit.App.Abstractions;
 using Bit.App.Services;
@@ -13,7 +15,9 @@ using Bit.Droid.Services;
 using Bit.Droid.Utilities;
 using Plugin.CurrentActivity;
 using Plugin.Fingerprint;
-using Plugin.Fingerprint.Abstractions;
+#if !FDROID
+using Android.Gms.Security;
+#endif
 
 namespace Bit.Droid
 {
@@ -23,7 +27,11 @@ namespace Bit.Droid
     [Application(Debuggable = false)]
 #endif
     [Register("com.x8bit.bitwarden.MainApplication")]
+#if FDROID
     public class MainApplication : Application
+#else
+    public class MainApplication : Application, ProviderInstaller.IProviderInstallListener
+#endif
     {
         public MainApplication(IntPtr handle, JniHandleOwnership transer)
           : base(handle, transer)
@@ -38,6 +46,12 @@ namespace Bit.Droid
                     Task.Delay(2000).Wait();
                 }
             }
+#if !FDROID
+            if(Build.VERSION.SdkInt <= BuildVersionCodes.Kitkat)
+            {
+                ProviderInstaller.InstallIfNeededAsync(ApplicationContext, this);
+            }
+#endif
         }
 
         public override void OnCreate()
@@ -47,6 +61,14 @@ namespace Bit.Droid
             CrossCurrentActivity.Current.Init(this);
         }
 
+        public void OnProviderInstallFailed(int errorCode, Intent recoveryIntent)
+        {
+        }
+
+        public void OnProviderInstalled()
+        {
+        }
+
         private void RegisterLocalServices()
         {
             ServiceContainer.Register<ILogService>("logService", new AndroidLogService());
@@ -73,7 +95,7 @@ namespace Bit.Droid
             CrossFingerprint.SetDialogFragmentType<CustomFingerprintDialogFragment>();
 
             var preferencesStorage = new PreferencesStorageService(null);
-            var documentsPath = Environment.GetFolderPath(Environment.SpecialFolder.Personal);
+            var documentsPath = System.Environment.GetFolderPath(System.Environment.SpecialFolder.Personal);
             var liteDbStorage = new LiteDbStorageService(Path.Combine(documentsPath, "bitwarden.db"));
             liteDbStorage.InitAsync();
             var localizeService = new LocalizeService();

src/Android/Properties/AndroidManifest.xml

@@ -3,7 +3,7 @@
   xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:tools="http://schemas.android.com/tools"
   android:versionCode="1"
-  android:versionName="2.0.0"
+  android:versionName="2.0.3"
   package="com.x8bit.bitwarden">
 
   <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="28" />
@@ -13,6 +13,7 @@
   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
   <uses-permission android:name="android.permission.CAMERA" />
   <uses-permission android:name="android.permission.USE_FINGERPRINT" />
+  <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
   <uses-permission android:name="com.samsung.android.providers.context.permission.WRITE_USE_APP_FEATURE_SURVEY" />
 
   <uses-feature android:name="android.hardware.camera" android:required="false" />

src/Android/Resources/values/styles.xml

@@ -59,7 +59,7 @@
     <item name="colorPrimary">@android:color/black</item>
     <item name="colorPrimaryDark">@android:color/black</item>
     <item name="colorControlNormal">@color/black_border</item>
-    <item name="android:navigationBarColor">@android:color/black</item>
+    <item name="android:navigationBarColor">@android:color/transparent</item>
   </style>
 
   <!-- Nord theme -->

src/Android/Services/DeviceActionService.cs

@@ -651,15 +651,19 @@ namespace Bit.Droid.Services
 
         private async Task CopyTotpAsync(CipherView cipher)
         {
-            var autoCopyDisabled = await _storageService.GetAsync<bool?>(Constants.DisableAutoTotpCopyKey);
-            var canAccessPremium = await ServiceContainer.Resolve<IUserService>("userService").CanAccessPremiumAsync();
-            if((canAccessPremium || cipher.OrganizationUseTotp) && !autoCopyDisabled.GetValueOrDefault() &&
-                !string.IsNullOrWhiteSpace(cipher?.Login?.Totp))
+            if(!string.IsNullOrWhiteSpace(cipher?.Login?.Totp))
             {
-                var totp = await ServiceContainer.Resolve<ITotpService>("totpService").GetCodeAsync(cipher.Login.Totp);
-                if(totp != null)
+                var userService = ServiceContainer.Resolve<IUserService>("userService");
+                var autoCopyDisabled = await _storageService.GetAsync<bool?>(Constants.DisableAutoTotpCopyKey);
+                var canAccessPremium = await userService.CanAccessPremiumAsync();
+                if((canAccessPremium || cipher.OrganizationUseTotp) && !autoCopyDisabled.GetValueOrDefault())
                 {
-                    CopyToClipboard(totp);
+                    var totpService = ServiceContainer.Resolve<ITotpService>("totpService");
+                    var totp = await totpService.GetCodeAsync(cipher.Login.Totp);
+                    if(totp != null)
+                    {
+                        CopyToClipboard(totp);
+                    }
                 }
             }
         }

src/Android/ci-build-apks.ps1

@@ -3,7 +3,9 @@
 $androidPath = $($rootPath + "\src\Android\Android.csproj");
 $appPath = $($rootPath + "\src\App\App.csproj");
 
+echo "########################################"
 echo "##### Increment Version"
+echo "########################################"
 
 $androidManifest = $($rootPath + "\src\Android\Properties\AndroidManifest.xml");
 
@@ -15,35 +17,73 @@ $node.SetAttribute("android:versionCode", $env:APPVEYOR_BUILD_NUMBER);
 
 $xml.Save($androidManifest);
 
+echo "########################################"
 echo "##### Decrypt Keystore"
+echo "########################################"
 
 $encKeystorePath = $($rootPath + "\src\Android\8bit.keystore.enc");
 $secureFilePath = $($rootPath + "\secure-file\tools\secure-file.exe");
 
 Invoke-Expression "& `"$secureFilePath`" -decrypt $($encKeystorePath) -secret $($env:keystore_dec_secret)"
 
+echo "########################################"
 echo "##### Sign Release Configuration"
+echo "########################################"
 
-msbuild "$($androidPath)" "/t:SignAndroidPackage" "/p:Configuration=Release" "/p:AndroidKeyStore=true" "/p:AndroidSigningKeyAlias=bitwarden" "/p:AndroidSigningKeyPass=$($env:keystore_password)" "/p:AndroidSigningKeyStore=8bit.keystore" "/p:AndroidSigningStorePass=$($env:keystore_password)" "/v:quiet"
-
+msbuild "$($androidPath)" "/t:SignAndroidPackage" "/p:Configuration=Release" "/p:AndroidKeyStore=true" `
+    "/p:AndroidSigningKeyAlias=bitwarden" "/p:AndroidSigningKeyPass=$($env:keystore_password)" `
+    "/p:AndroidSigningKeyStore=8bit.keystore" "/p:AndroidSigningStorePass=$($env:keystore_password)" "/v:quiet"
+	
+echo "########################################"
 echo "##### Copy Release apk to project root"
+echo "########################################"
 
 $signedApkPath = $($rootPath + "\src\Android\bin\Release\com.x8bit.bitwarden-Signed.apk");
 $signedApkDestPath = $($rootPath + "\com.x8bit.bitwarden.apk");
 
 Copy-Item $signedApkPath $signedApkDestPath
 
+echo "########################################"
 echo "##### Clean Android and App"
+echo "########################################"
 
 msbuild "$($androidPath)" "/t:Clean" "/p:Configuration=FDroid"
 msbuild "$($appPath)" "/t:Clean" "/p:Configuration=FDroid"
 
+echo "########################################"
 echo "##### Backup project files"
+echo "########################################"
 
+Copy-Item $androidManifest $($androidManifest + ".original");
 Copy-Item $androidPath $($androidPath + ".original");
 Copy-Item $appPath $($appPath + ".original");
 
+
+echo "########################################"
+echo "##### Cleanup Android Manifest"
+echo "########################################"
+
+$xml=New-Object XML;
+$xml.Load($androidManifest);
+
+$nsAndroid=New-Object System.Xml.XmlNamespaceManager($xml.NameTable);
+$nsAndroid.AddNamespace("android", "http://schemas.android.com/apk/res/android");
+
+$firebaseReceiver1=$xml.SelectSingleNode(`
+    "/manifest/application/receiver[@android:name='com.google.firebase.iid.FirebaseInstanceIdInternalReceiver']", `
+    $nsAndroid);
+$firebaseReceiver1.ParentNode.RemoveChild($firebaseReceiver1);
+
+$firebaseReceiver2=$xml.SelectSingleNode(`
+    "/manifest/application/receiver[@android:name='com.google.firebase.iid.FirebaseInstanceIdReceiver']", `
+    $nsAndroid);
+$firebaseReceiver2.ParentNode.RemoveChild($firebaseReceiver2);
+
+$xml.Save($androidManifest);
+
+echo "########################################"
 echo "##### Uninstall from Android.csproj"
+echo "########################################"
 
 $xml=New-Object XML;
 $xml.Load($androidPath);
@@ -51,12 +91,19 @@ $xml.Load($androidPath);
 $ns=New-Object System.Xml.XmlNamespaceManager($xml.NameTable);
 $ns.AddNamespace("ns", $xml.DocumentElement.NamespaceURI);
 
-$firebaseNode=$xml.SelectSingleNode("/ns:Project/ns:ItemGroup/ns:PackageReference[@Include='Xamarin.Firebase.Messaging']", $ns);
+$firebaseNode=$xml.SelectSingleNode(`
+    "/ns:Project/ns:ItemGroup/ns:PackageReference[@Include='Xamarin.Firebase.Messaging']", $ns);
 $firebaseNode.ParentNode.RemoveChild($firebaseNode);
 
+$safetyNetNode=$xml.SelectSingleNode(`
+    "/ns:Project/ns:ItemGroup/ns:PackageReference[@Include='Xamarin.GooglePlayServices.SafetyNet']", $ns);
+$safetyNetNode.ParentNode.RemoveChild($safetyNetNode);
+
 $xml.Save($androidPath);
 
+echo "########################################"
 echo "##### Uninstall from App.csproj"
+echo "########################################"
 
 $xml=New-Object XML;
 $xml.Load($appPath);
@@ -66,22 +113,31 @@ $hockeyNode.ParentNode.RemoveChild($hockeyNode);
 
 $xml.Save($appPath);
 
+echo "########################################"
 echo "##### Restore NuGet"
-
-$nugetPath = $($rootPath + "\nuget.exe");
+echo "########################################"
 
 Invoke-Expression "& nuget restore"
 
+echo "########################################"
 echo "##### Build and Sign FDroid Configuration"
+echo "########################################"
 
-msbuild "$($androidPath)" "/logger:C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll" "/p:Configuration=FDroid"
-msbuild "$($androidPath)" "/t:SignAndroidPackage" "/p:Configuration=FDroid" "/p:AndroidKeyStore=true" "/p:AndroidSigningKeyAlias=bitwarden" "/p:AndroidSigningKeyPass=$($env:keystore_password)" "/p:AndroidSigningKeyStore=8bit.keystore" "/p:AndroidSigningStorePass=$($env:keystore_password)" "/v:quiet"
-
+msbuild "$($androidPath)" "/logger:C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll" `
+    "/p:Configuration=FDroid"
+msbuild "$($androidPath)" "/t:SignAndroidPackage" "/p:Configuration=FDroid" "/p:AndroidKeyStore=true" `
+    "/p:AndroidSigningKeyAlias=bitwarden" "/p:AndroidSigningKeyPass=$($env:keystore_password)" `
+    "/p:AndroidSigningKeyStore=8bit.keystore" "/p:AndroidSigningStorePass=$($env:keystore_password)" "/v:quiet"
+	
+echo "########################################"
 echo "##### Copy FDroid apk to project root"
+echo "########################################"
 
 $signedApkPath = $($rootPath + "\src\Android\bin\FDroid\com.x8bit.bitwarden-Signed.apk");
 $signedApkDestPath = $($rootPath + "\com.x8bit.bitwarden-fdroid.apk");
 
 Copy-Item $signedApkPath $signedApkDestPath
 
+echo "########################################"
 echo "##### Done"
+echo "########################################"

src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs

@@ -6,7 +6,6 @@ using Bit.Core.Abstractions;
 using Bit.Core.Enums;
 using Bit.Core.Utilities;
 using System;
-using System.Linq;
 using System.Threading.Tasks;
 using Xamarin.Forms;
 
@@ -78,6 +77,10 @@ namespace Bit.App.Pages
                 }
                 else if(message.Command == "syncCompleted")
                 {
+                    if(!_vm.LoadedOnce)
+                    {
+                        return;
+                    }
                     await Task.Delay(500);
                     Device.BeginInvokeOnMainThread(() =>
                     {
@@ -92,7 +95,15 @@ namespace Bit.App.Pages
             {
                 if(!_syncService.SyncInProgress)
                 {
-                    await _vm.LoadAsync();
+                    try
+                    {
+                        await _vm.LoadAsync();
+                    }
+                    catch(Exception e) when(e.Message.Contains("No key."))
+                    {
+                        await Task.Delay(5000);
+                        await _vm.LoadAsync();
+                    }
                 }
                 else
                 {

src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs

@@ -126,6 +126,7 @@ namespace Bit.App.Pages
         public ExtendedObservableCollection<GroupingsPageListGroup> GroupedItems { get; set; }
         public Command RefreshCommand { get; set; }
         public Command<CipherView> CipherOptionsCommand { get; set; }
+        public bool LoadedOnce { get; set; }
 
         public async Task LoadAsync()
         {
@@ -134,6 +135,7 @@ namespace Bit.App.Pages
                 return;
             }
             _doingLoad = true;
+            LoadedOnce = true;
             ShowNoData = false;
             Loading = true;
             ShowList = false;

src/App/Utilities/AppHelpers.cs

@@ -29,7 +29,12 @@ namespace Bit.App.Utilities
                 }
                 if(!string.IsNullOrWhiteSpace(cipher.Login.Totp))
                 {
-                    options.Add(AppResources.CopyTotp);
+                    var userService = ServiceContainer.Resolve<IUserService>("userService");
+                    var canAccessPremium = await userService.CanAccessPremiumAsync();
+                    if(canAccessPremium || cipher.OrganizationUseTotp)
+                    {
+                        options.Add(AppResources.CopyTotp);
+                    }
                 }
                 if(cipher.Login.CanLaunch)
                 {

src/iOS/Info.plist

@@ -11,7 +11,7 @@
 	<key>CFBundleIdentifier</key>
 	<string>com.8bit.bitwarden</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.0.0</string>
+	<string>2.0.3</string>
 	<key>CFBundleVersion</key>
 	<string>50</string>
 	<key>CFBundleIconName</key>