github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PM-25239] Remove unnecessary vault sync from Fido2CredentialStoreImpl (#5794)

Browse Source
This commit is contained in:
Patrick Honkonen
2025-08-28 11:47:44 -04:00
committed by GitHub
parent 2b35ac0d3a
commit f7139b8b91
1 changed files with 10 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt
View File

@@ -12,7 +12,6 @@ import com.x8bit.bitwarden.data.platform.error.NoActiveUserException
import com.x8bit.bitwarden.data.vault.datasource.sdk.VaultSdkSource
import com.x8bit.bitwarden.data.vault.manager.model.GetCipherResult
import com.x8bit.bitwarden.data.vault.repository.VaultRepository
import com.x8bit.bitwarden.data.vault.repository.model.SyncVaultDataResult
import timber.log.Timber
/**
@@ -28,21 +27,13 @@ class Fido2CredentialStoreImpl(
/**
* Return all active ciphers that contain FIDO 2 credentials.
*/
override suspend fun allCredentials(): List<CipherListView> {
val syncResult = vaultRepository.syncForResult()
if (syncResult is SyncVaultDataResult.Error) {
syncResult.throwable
?.let { throw it }
?: throw IllegalStateException("Sync failed.")
}
return vaultRepository
.decryptCipherListResultStateFlow
.value
.data
?.successes
.orEmpty()
.filter { it.isActiveWithFido2Credentials }
}
override suspend fun allCredentials(): List<CipherListView> = vaultRepository
.decryptCipherListResultStateFlow
.value
.data
?.successes
.orEmpty()
.filter { it.isActiveWithFido2Credentials }
/**
* Returns ciphers that contain FIDO 2 credentials for the given [ripId] with the provided
@@ -51,15 +42,8 @@ class Fido2CredentialStoreImpl(
* @param ids Optional list of FIDO 2 credential ID's to find.
* @param ripId Relying Party ID to find.
*/
override suspend fun findCredentials(ids: List<ByteArray>?, ripId: String): List<CipherView> {
val syncResult = vaultRepository.syncForResult()
if (syncResult is SyncVaultDataResult.Error) {
syncResult.throwable
?.let { throw it }
?: throw IllegalStateException("Sync failed.")
}
return vaultRepository
override suspend fun findCredentials(ids: List<ByteArray>?, ripId: String): List<CipherView> =
vaultRepository
.decryptCipherListResultStateFlow
.value
.data
@@ -78,7 +62,6 @@ class Fido2CredentialStoreImpl(
.toCipherViewOrNull()
}
}
}
/**
* Save the provided [cred] to the users vault.
@@ -95,7 +78,7 @@ class Fido2CredentialStoreImpl(
?: vaultRepository.createCipher(decryptedCipherView)
}
.onFailure { throw it }
}
}
/**
* Return a filtered list containing elements that match the given [relyingPartyId] and a