github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-04-29 12:32:26 -05:00
Code Issues 936 Packages Projects Releases 122 Wiki Activity

[PM-25027] Rename "Ask to add login" to "Ask to add item" (#5758)

Browse Source
This commit is contained in:
Patrick Honkonen
2025-08-20 12:03:36 -04:00
committed by GitHub
parent b3528249e9
commit d8e319948c
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt
View File

@@ -302,8 +302,8 @@ private fun AutoFillScreenContent(
) )
Spacer(modifier = Modifier.height(8.dp)) Spacer(modifier = Modifier.height(8.dp))
BitwardenSwitch( BitwardenSwitch(
label = stringResource(id = BitwardenString.ask_to_add_login), label = stringResource(id = BitwardenString.ask_to_add_item),
supportingText = stringResource(id = BitwardenString.ask_to_add_login_description), supportingText = stringResource(id = BitwardenString.ask_to_add_item_description),
isChecked = state.isAskToAddLoginEnabled, isChecked = state.isAskToAddLoginEnabled,
onCheckedChange = autoFillHandlers.onAskToAddLoginClick, onCheckedChange = autoFillHandlers.onAskToAddLoginClick,
cardStyle = CardStyle.Full, cardStyle = CardStyle.Full,

10
app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt
View File

@@ -405,23 +405,23 @@ class AutoFillScreenTest : BitwardenComposeTest() {
} }
@Test @Test
fun `on ask to add login toggle should send AskToAddLoginClick`() { fun `on Ask to add item toggle should send AskToAddLoginClick`() {
composeTestRule composeTestRule
.onNodeWithText("Ask to add login") .onNodeWithText("Ask to add item")
.performScrollTo() .performScrollTo()
.performClick() .performClick()
verify { viewModel.trySendAction(AutoFillAction.AskToAddLoginClick(true)) } verify { viewModel.trySendAction(AutoFillAction.AskToAddLoginClick(true)) }
} }
@Test @Test
fun `ask to add login should be toggled on or off according to state`() { fun `Ask to add item should be toggled on or off according to state`() {
composeTestRule composeTestRule
.onNodeWithText("Ask to add login") .onNodeWithText("Ask to add item")
.performScrollTo() .performScrollTo()
.assertIsOff() .assertIsOff()
mutableStateFlow.update { it.copy(isAskToAddLoginEnabled = true) } mutableStateFlow.update { it.copy(isAskToAddLoginEnabled = true) }
composeTestRule composeTestRule
.onNodeWithText("Ask to add login") .onNodeWithText("Ask to add item")
.performScrollTo() .performScrollTo()
.assertIsOn() .assertIsOn()
} }

4
ui/src/main/res/values/strings.xml
View File

@@ -365,8 +365,8 @@ Scanning will happen automatically.</string>
<string name="exit_confirmation">Are you sure you want to exit Bitwarden?</string> <string name="exit_confirmation">Are you sure you want to exit Bitwarden?</string>
<string name="require_master_password_on_app_restart">Require master password on app restart?</string> <string name="require_master_password_on_app_restart">Require master password on app restart?</string>
<string name="pin_require_master_password_restart">Do you want to require unlocking with your master password when the application is restarted?</string> <string name="pin_require_master_password_restart">Do you want to require unlocking with your master password when the application is restarted?</string>
<string name="ask_to_add_login">Ask to add login</string> <string name="ask_to_add_item">Ask to add item</string>
<string name="ask_to_add_login_description">Ask to add an item if one isn\'t found in your vault.</string> <string name="ask_to_add_item_description">Ask to add an item if one isn\'t found in your vault.</string>
<string name="on_restart">On app restart</string> <string name="on_restart">On app restart</string>
<string name="capitalize">Capitalize</string> <string name="capitalize">Capitalize</string>
<string name="include_number">Include number</string> <string name="include_number">Include number</string>