From d8e319948ca166d8e4e1637063e62ef808b06eb3 Mon Sep 17 00:00:00 2001
From: Patrick Honkonen <1883101+SaintPatrck@users.noreply.github.com>
Date: Wed, 20 Aug 2025 12:03:36 -0400
Subject: [PATCH] [PM-25027] Rename "Ask to add login" to "Ask to add item"
(#5758)
---
.../feature/settings/autofill/AutoFillScreen.kt | 4 ++--
.../feature/settings/autofill/AutoFillScreenTest.kt | 10 +++++-----
ui/src/main/res/values/strings.xml | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt b/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt
index 3282649472..9ff4afb15b 100644
--- a/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt
+++ b/app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt
@@ -302,8 +302,8 @@ private fun AutoFillScreenContent(
)
Spacer(modifier = Modifier.height(8.dp))
BitwardenSwitch(
- label = stringResource(id = BitwardenString.ask_to_add_login),
- supportingText = stringResource(id = BitwardenString.ask_to_add_login_description),
+ label = stringResource(id = BitwardenString.ask_to_add_item),
+ supportingText = stringResource(id = BitwardenString.ask_to_add_item_description),
isChecked = state.isAskToAddLoginEnabled,
onCheckedChange = autoFillHandlers.onAskToAddLoginClick,
cardStyle = CardStyle.Full,
diff --git a/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt b/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt
index c32dfa2e05..246b6b7575 100644
--- a/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt
+++ b/app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt
@@ -405,23 +405,23 @@ class AutoFillScreenTest : BitwardenComposeTest() {
}
@Test
- fun `on ask to add login toggle should send AskToAddLoginClick`() {
+ fun `on Ask to add item toggle should send AskToAddLoginClick`() {
composeTestRule
- .onNodeWithText("Ask to add login")
+ .onNodeWithText("Ask to add item")
.performScrollTo()
.performClick()
verify { viewModel.trySendAction(AutoFillAction.AskToAddLoginClick(true)) }
}
@Test
- fun `ask to add login should be toggled on or off according to state`() {
+ fun `Ask to add item should be toggled on or off according to state`() {
composeTestRule
- .onNodeWithText("Ask to add login")
+ .onNodeWithText("Ask to add item")
.performScrollTo()
.assertIsOff()
mutableStateFlow.update { it.copy(isAskToAddLoginEnabled = true) }
composeTestRule
- .onNodeWithText("Ask to add login")
+ .onNodeWithText("Ask to add item")
.performScrollTo()
.assertIsOn()
}
diff --git a/ui/src/main/res/values/strings.xml b/ui/src/main/res/values/strings.xml
index 3b7924e27a..9800710c1a 100644
--- a/ui/src/main/res/values/strings.xml
+++ b/ui/src/main/res/values/strings.xml
@@ -365,8 +365,8 @@ Scanning will happen automatically.
Are you sure you want to exit Bitwarden?
Require master password on app restart?
Do you want to require unlocking with your master password when the application is restarted?
- Ask to add login
- Ask to add an item if one isn\'t found in your vault.
+ Ask to add item
+ Ask to add an item if one isn\'t found in your vault.
On app restart
Capitalize
Include number