Adding screen capture allow key to settings disk source (#780)

This commit is contained in:
Joshua Queen
2024-06-20 17:08:07 +01:00
committed by Álison Fernandes
parent 2f2f5703a7
commit cd020f2af9
4 changed files with 92 additions and 2 deletions
@@ -104,6 +104,10 @@ class SettingsDiskSourceTest {
userId = userId,
lastSyncTime = Instant.parse("2023-10-27T12:00:00Z"),
)
settingsDiskSource.storeScreenCaptureAllowed(
userId = userId,
isScreenCaptureAllowed = true,
)
settingsDiskSource.clearData(userId = userId)
@@ -116,6 +120,7 @@ class SettingsDiskSourceTest {
assertNull(settingsDiskSource.getBlockedAutofillUris(userId = userId))
assertNull(settingsDiskSource.getApprovePasswordlessLoginsEnabled(userId = userId))
assertNull(settingsDiskSource.getLastSyncTime(userId = userId))
assertNull(settingsDiskSource.getScreenCaptureAllowed(userId = userId))
}
@Test
@@ -717,4 +722,53 @@ class SettingsDiskSourceTest {
)
assertFalse(fakeSharedPreferences.contains(approvePasswordlessLoginsKey))
}
@Test
fun `getScreenCaptureAllowed should pull from SharedPreferences`() {
val screenCaptureAllowBaseKey = "bwPreferencesStorage:screenCaptureAllowed"
val mockUserId = "mockUserId"
val isScreenCaptureAllowed = true
fakeSharedPreferences.edit {
putBoolean("${screenCaptureAllowBaseKey}_$mockUserId", isScreenCaptureAllowed)
}
val actual = settingsDiskSource.getScreenCaptureAllowed(userId = mockUserId)
assertEquals(
isScreenCaptureAllowed,
actual,
)
}
@Test
fun `storeScreenCaptureAllowed for non-null values should update SharedPreferences`() {
val screenCaptureAllowBaseKey = "bwPreferencesStorage:screenCaptureAllowed"
val mockUserId = "mockUserId"
val isScreenCaptureAllowed = true
settingsDiskSource.storeScreenCaptureAllowed(
userId = mockUserId,
isScreenCaptureAllowed = isScreenCaptureAllowed,
)
val actual = fakeSharedPreferences.getBoolean(
"${screenCaptureAllowBaseKey}_$mockUserId",
false,
)
assertEquals(
isScreenCaptureAllowed,
actual,
)
}
@Test
fun `storeScreenCaptureAllowed for null values should clear SharedPreferences`() {
val screenCaptureAllowBaseKey = "bwPreferencesStorage:screenCaptureAllowed"
val mockUserId = "mockUserId"
val screenCaptureAllowKey = "${screenCaptureAllowBaseKey}_$mockUserId"
fakeSharedPreferences.edit {
putBoolean(screenCaptureAllowKey, true)
}
settingsDiskSource.storeScreenCaptureAllowed(
userId = mockUserId,
isScreenCaptureAllowed = null,
)
assertFalse(fakeSharedPreferences.contains(screenCaptureAllowKey))
}
}
@@ -42,10 +42,9 @@ class FakeSettingsDiskSource : SettingsDiskSource {
private val storedPullToRefreshEnabled = mutableMapOf<String, Boolean?>()
private val storedInlineAutofillEnabled = mutableMapOf<String, Boolean?>()
private val storedBlockedAutofillUris = mutableMapOf<String, List<String>?>()
private var storedIsIconLoadingDisabled: Boolean? = null
private val storedApprovePasswordLoginsEnabled = mutableMapOf<String, Boolean?>()
private val storedScreenCaptureAllowed = mutableMapOf<String, Boolean?>()
override var appLanguage: AppLanguage? = null
@@ -81,6 +80,7 @@ class FakeSettingsDiskSource : SettingsDiskSource {
storedPullToRefreshEnabled.remove(userId)
storedInlineAutofillEnabled.remove(userId)
storedBlockedAutofillUris.remove(userId)
storedScreenCaptureAllowed.remove(userId)
mutableVaultTimeoutActionsFlowMap.remove(userId)
mutableVaultTimeoutInMinutesFlowMap.remove(userId)
@@ -190,6 +190,16 @@ class FakeSettingsDiskSource : SettingsDiskSource {
storedApprovePasswordLoginsEnabled[userId] = isApprovePasswordlessLoginsEnabled
}
override fun getScreenCaptureAllowed(userId: String): Boolean? =
storedScreenCaptureAllowed[userId]
override fun storeScreenCaptureAllowed(
userId: String,
isScreenCaptureAllowed: Boolean?,
) {
storedScreenCaptureAllowed[userId] = isScreenCaptureAllowed
}
//region Private helper functions
private fun getMutableLastSyncTimeFlow(