github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 20:20:03 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

BIT-589 Prevent crash on Landing when navigating with empty input (#59)

Browse Source
This commit is contained in:
Andrew Haisting
2023-09-21 11:47:28 -05:00
committed by GitHub
parent 61793d6659
commit 8c51f36008
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt
View File

@@ -49,6 +49,10 @@ class LandingViewModel @Inject constructor(
}
private fun handleContinueButtonClicked() {
// TODO: add actual validation here: BIT-193
if (mutableStateFlow.value.emailInput.isBlank()) {
return
}
sendEvent(LandingEvent.NavigateToLogin(mutableStateFlow.value.emailInput))
}

11
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt
View File

@@ -34,15 +34,24 @@ class LandingViewModelTest : BaseViewModelTest() {
@Test
fun `ContinueButtonClick should emit NavigateToLogin`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.trySendAction(LandingAction.EmailInputChanged("input"))
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
assertEquals(
LandingEvent.NavigateToLogin(""),
LandingEvent.NavigateToLogin("input"),
awaitItem(),
)
}
}
@Test
fun `ContinueButtonClick with empty input should do nothing`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
}
}
@Test
fun `CreateAccountClick should emit NavigateToCreateAccount`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())