[PM-6702] Fix typos

This commit is contained in:
André Bispo
2024-07-22 18:00:03 +01:00
parent fd8068f5f7
commit 8484d111a6
6 changed files with 9 additions and 14 deletions

View File

@@ -1,7 +1,6 @@
package com.x8bit.bitwarden.data.auth.datasource.network.model
import com.x8bit.bitwarden.data.auth.datasource.network.model.RegisterFinishRequestJson.Keys
import com.x8bit.bitwarden.data.auth.datasource.network.model.RegisterRequestJson.Keys
import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
@@ -9,12 +8,12 @@ import kotlinx.serialization.Serializable
* Request body for register.
*
* @param email the email to be registered.
* @param emailVerificationToken token used to finish the registration process.
* @param masterPasswordHash the master password (encrypted).
* @param masterPasswordHint the hint for the master password (nullable).
* @param emailVerificationToken token used to finish the registration process.
* @param captchaResponse the captcha bypass token.
* @param key the user key for the request (encrypted).
* @param keys a [Keys] object containing public and private keys.
* @param userSymmetricKey the user key for the request (encrypted).
* @param userAsymmetricKeys a [Keys] object containing public and private keys.
* @param kdfType the kdf type represented as an [Int].
* @param kdfIterations the number of kdf iterations.
*/

View File

@@ -53,10 +53,7 @@ class IdentityServiceImpl(
.registerFinish(body)
.recoverCatching { throwable ->
val bitwardenError = throwable.toBitwardenError()
bitwardenError.parseErrorBodyOrNull<RegisterResponseJson.CaptchaRequired>(
code = 400,
json = json,
) ?: bitwardenError.parseErrorBodyOrNull<RegisterResponseJson.Invalid>(
bitwardenError.parseErrorBodyOrNull<RegisterResponseJson.Invalid>(
codes = listOf(400, 429),
json = json,
) ?: bitwardenError.parseErrorBodyOrNull<RegisterResponseJson.Error>(

View File

@@ -15,7 +15,6 @@ private const val KEY_STATE = "state"
/**
* Models logic for the check email screen.
*/
@Suppress("TooManyFunctions")
@HiltViewModel
class CheckEmailViewModel @Inject constructor(
savedStateHandle: SavedStateHandle,
@@ -65,7 +64,7 @@ sealed class CheckEmailEvent {
data object NavigateToEmailApp : CheckEmailEvent()
/**
* Navigate to email app.
* Navigate to landing screen.
*/
data object NavigateBackToLanding : CheckEmailEvent()
}

View File

@@ -17,7 +17,7 @@ private const val COMPLETE_REGISTRATION_ROUTE =
"$COMPLETE_REGISTRATION_PREFIX/{$EMAIL_ADDRESS}/{$VERIFICATION_TOKEN}/{$FROM_EMAIL}"
/**
* Class to retrieve login with device arguments from the [SavedStateHandle].
* Class to retrieve complete registration arguments from the [SavedStateHandle].
*/
@OmitFromCoverage
data class CompleteRegistrationArgs(

View File

@@ -160,7 +160,7 @@ class LandingViewModel @Inject constructor(
}
private fun handleCreateAccountClicked() {
// TODO ADD FEATURE FLAG email-verification
// TODO PM-9401: ADD FEATURE FLAG email-verification
if (true)
sendEvent(LandingEvent.NavigateToStartRegistration)
else

View File

@@ -294,7 +294,7 @@ sealed class StartRegistrationEvent {
) : StartRegistrationEvent()
/**
* Navigates to the complete registration screen.
* Navigates to the check email screen.
*/
data class NavigateToCheckEmail(
val email: String,
@@ -326,7 +326,7 @@ sealed class StartRegistrationEvent {
*/
sealed class StartRegistrationAction {
/**
* User clicked submit.
* User clicked continue.
*/
data object ContinueClick : StartRegistrationAction()