fixing static analisys issues

This commit is contained in:
ifernandezdiaz
2025-07-18 11:09:40 -03:00
parent 62b9088a5a
commit 7a985557aa
8 changed files with 11 additions and 15 deletions

View File

@@ -16,11 +16,11 @@ import androidx.compose.ui.test.performClick
*/
abstract class Page(protected val composeTestRule: ComposeTestRule) {
companion object {
val TIMEOUT_MILLIS = 30000L
const val TIMEOUT_MILLIS = 30000L
}
/**
* Waits for an element with the specified test tag to be present and returns its SemanticsNodeInteraction.
* Waits for an element with the specified test tag to be present.
* @param testTag The test tag of the element to wait for
* @return SemanticsNodeInteraction for the found element
* @throws AssertionError if the element is not found within the timeout period

View File

@@ -1,8 +1,8 @@
package com.x8bit.bitwarden.e2e.pages
import androidx.compose.ui.test.*
import androidx.compose.ui.test.performTextInput
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.junit4.ComposeTestRule
import com.x8bit.bitwarden.ui.platform.feature.search.SearchTypeData
import e2e.pageObjects.Page
import e2e.pageObjects.login.EnvironmentSettingsPage
import e2e.pageObjects.vault.VaultPage
@@ -17,7 +17,9 @@ class LoginPage(composeTestRule: ComposeTestRule) : Page(composeTestRule) {
private val emailField by lazy { getElement("EmailAddressEntry") }
private val masterPasswordField by lazy { getElement("MasterPasswordEntry") }
private val continueButton by lazy { getElement("ContinueButton") }
private val loginWithMasterPasswordButton by lazy { getElement("LogInWithMasterPasswordButton") }
private val loginWithMasterPasswordButton by lazy {
getElement("LogInWithMasterPasswordButton")
}
private val regionSelectorButton by lazy { getElement("RegionSelectorDropdown") }
private val openSettingsButton by lazy { getElement("AppSettingsButton") }
private val otherSettingsButton by lazy { getElement("OtherSettingsButton") }

View File

@@ -1,11 +1,9 @@
package e2e.pageObjects.login
import androidx.compose.ui.test.junit4.ComposeTestRule
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.performClick
import com.x8bit.bitwarden.e2e.pages.LoginPage
import e2e.pageObjects.Page
import e2e.pageObjects.vault.VaultPage
class MainPage(composeTestRule: ComposeTestRule) : Page(composeTestRule) {

View File

@@ -1,7 +1,7 @@
package e2e.pageObjects.settings
import androidx.compose.ui.test.junit4.ComposeTestRule
import androidx.compose.ui.test.*
import androidx.compose.ui.test.performClick
import e2e.pageObjects.Page
import e2e.pageObjects.settings.accountSecurity.AccountSecurityPage

View File

@@ -1,6 +1,8 @@
package e2e.pageObjects.settings.accountSecurity
import androidx.compose.ui.test.*
import androidx.compose.ui.test.assertIsNotDisplayed
import androidx.compose.ui.test.performScrollTo
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.junit4.ComposeTestRule
import e2e.pageObjects.Page
import e2e.pageObjects.vault.UnlockVaultPage

View File

@@ -2,7 +2,6 @@ package e2e.pageObjects.vault
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.junit4.ComposeTestRule
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.performTextInput
import e2e.pageObjects.Page
@@ -24,5 +23,4 @@ class UnlockVaultPage(composeTestRule: ComposeTestRule) : Page(composeTestRule)
unlockVaultButtonTag.performClick()
return VaultPage(composeTestRule)
}
}

View File

@@ -1,11 +1,8 @@
package e2e.pageObjects.vault
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsNotDisplayed
import androidx.compose.ui.test.junit4.ComposeTestRule
import androidx.compose.ui.test.onNodeWithTag
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.performTextInput
import e2e.pageObjects.Page
import e2e.pageObjects.settings.SettingsPage

View File

@@ -1,6 +1,5 @@
package e2e.tests
import androidx.compose.ui.test.*
import androidx.test.ext.junit.runners.AndroidJUnit4
import e2e.pageObjects.login.MainPage
import org.junit.Test