PM-21088: Remove the unused IgnoreEnvironmentCheck feature flag (#5119)

This commit is contained in:
David Perez
2025-05-01 11:49:58 -05:00
committed by GitHub
parent 0353f0c153
commit 32d0ca7bcd
6 changed files with 0 additions and 21 deletions

View File

@@ -34,7 +34,6 @@ sealed class FlagKey<out T : Any> {
VerifiedSsoDomainEndpoint,
CredentialExchangeProtocolImport,
CredentialExchangeProtocolExport,
IgnoreEnvironmentCheck,
MutualTls,
SingleTapPasskeyCreation,
SingleTapPasskeyAuthentication,
@@ -149,15 +148,6 @@ sealed class FlagKey<out T : Any> {
override val isRemotelyConfigured: Boolean = true
}
/**
* Data object holding the feature flag key to ignore an environment check.
*/
data object IgnoreEnvironmentCheck : FlagKey<Boolean>() {
override val keyName: String = "ignore-environment-check"
override val defaultValue: Boolean = false
override val isRemotelyConfigured: Boolean = false
}
/**
* Data object holding the feature flag key for the Mutual TLS feature.
*/

View File

@@ -34,7 +34,6 @@ fun <T : Any> FlagKey<T>.ListItemContent(
FlagKey.CredentialExchangeProtocolImport,
FlagKey.CredentialExchangeProtocolExport,
FlagKey.CipherKeyEncryption,
FlagKey.IgnoreEnvironmentCheck,
FlagKey.MutualTls,
FlagKey.SingleTapPasskeyCreation,
FlagKey.SingleTapPasskeyAuthentication,
@@ -94,7 +93,6 @@ private fun <T : Any> FlagKey<T>.getDisplayLabel(): String = when (this) {
FlagKey.CredentialExchangeProtocolImport -> stringResource(R.string.cxp_import)
FlagKey.CredentialExchangeProtocolExport -> stringResource(R.string.cxp_export)
FlagKey.CipherKeyEncryption -> stringResource(R.string.cipher_key_encryption)
FlagKey.IgnoreEnvironmentCheck -> stringResource(R.string.ignore_environment_check)
FlagKey.MutualTls -> stringResource(R.string.mutual_tls)
FlagKey.SingleTapPasskeyCreation -> stringResource(R.string.single_tap_passkey_creation)
FlagKey.SingleTapPasskeyAuthentication -> {

View File

@@ -21,7 +21,6 @@
<string name="restart_onboarding_carousel">Show Onboarding Carousel</string>
<string name="restart_onboarding_carousel_details">This will force the change to app state which will cause the first time carousel to show. The carousel will continue to show for any \"new\" account until a login is completed. May need to exit debug menu manually.</string>
<string name="cipher_key_encryption">Cipher Key Encryption</string>
<string name="ignore_environment_check">Ignore environment check</string>">
<string name="reset_coach_mark_tour_status">Reset all coach mark tours</string>
<string name="anon_addy_self_hosted_aliases">AnonAddy self-hosted aliases</string>
<string name="simple_login_self_hosted_aliases">SimpleLogin self-hosted aliases</string>

View File

@@ -257,7 +257,6 @@ class AuthRepositoryTest {
private val featureFlagManager: FeatureFlagManager = mockk(relaxed = true) {
every { getFeatureFlag(FlagKey.OnboardingFlow) } returns false
every { getFeatureFlag(FlagKey.IgnoreEnvironmentCheck) } returns false
}
private val firstTimeActionManager = mockk<FirstTimeActionManager> {

View File

@@ -53,10 +53,6 @@ class FlagKeyTest {
FlagKey.SingleTapPasskeyAuthentication.keyName,
"single-tap-passkey-authentication",
)
assertEquals(
FlagKey.IgnoreEnvironmentCheck.keyName,
"ignore-environment-check",
)
assertEquals(
FlagKey.MutualTls.keyName,
"mutual-tls",
@@ -137,7 +133,6 @@ class FlagKeyTest {
assertTrue(
listOf(
FlagKey.IgnoreEnvironmentCheck,
FlagKey.FlightRecorder,
FlagKey.PreAuthSettings,
).all {

View File

@@ -128,7 +128,6 @@ private val DEFAULT_MAP_VALUE: ImmutableMap<FlagKey<Any>, Any> = persistentMapOf
FlagKey.VerifiedSsoDomainEndpoint to true,
FlagKey.CredentialExchangeProtocolImport to true,
FlagKey.CredentialExchangeProtocolExport to true,
FlagKey.IgnoreEnvironmentCheck to true,
FlagKey.MutualTls to true,
FlagKey.SingleTapPasskeyCreation to true,
FlagKey.SingleTapPasskeyAuthentication to true,
@@ -149,7 +148,6 @@ private val UPDATED_MAP_VALUE: ImmutableMap<FlagKey<Any>, Any> = persistentMapOf
FlagKey.VerifiedSsoDomainEndpoint to false,
FlagKey.CredentialExchangeProtocolImport to false,
FlagKey.CredentialExchangeProtocolExport to false,
FlagKey.IgnoreEnvironmentCheck to false,
FlagKey.MutualTls to false,
FlagKey.SingleTapPasskeyCreation to false,
FlagKey.SingleTapPasskeyAuthentication to false,