github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-29 10:17:56 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PM-28835] Added validations to prevent duplicate press on buttons (#6209)

Browse Source
This commit is contained in:
aj-rosado
2025-12-03 17:46:03 +00:00
committed by GitHub
parent 2c01abda46
commit 26e7178300
4 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenFilledButton.kt
+2 -1
View File
@@ -18,6 +18,7 @@ import com.bitwarden.ui.platform.base.util.cardStyle
import com.bitwarden.ui.platform.components.button.color.bitwardenFilledButtonColors
import com.bitwarden.ui.platform.components.model.CardStyle
import com.bitwarden.ui.platform.components.util.rememberVectorPainter
import com.bitwarden.ui.platform.components.util.throttledClick
import com.bitwarden.ui.platform.resource.BitwardenDrawable
import com.bitwarden.ui.platform.theme.BitwardenTheme
@@ -48,7 +49,7 @@ fun BitwardenFilledButton(
modifier = modifier
.semantics(mergeDescendants = true) {}
.cardStyle(cardStyle = cardStyle, padding = cardInsets),
onClick = onClick,
onClick = throttledClick(onClick = onClick),
enabled = isEnabled,
contentPadding = PaddingValues(
top = 10.dp,
ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenOutlinedButton.kt
+2 -1
View File
@@ -19,6 +19,7 @@ import com.bitwarden.ui.platform.components.button.color.bitwardenOutlinedButton
import com.bitwarden.ui.platform.components.button.model.BitwardenOutlinedButtonColors
import com.bitwarden.ui.platform.components.model.CardStyle
import com.bitwarden.ui.platform.components.util.rememberVectorPainter
import com.bitwarden.ui.platform.components.util.throttledClick
import com.bitwarden.ui.platform.resource.BitwardenDrawable
import com.bitwarden.ui.platform.theme.BitwardenTheme
@@ -50,7 +51,7 @@ fun BitwardenOutlinedButton(
modifier = modifier
.semantics(mergeDescendants = true) { }
.cardStyle(cardStyle = cardStyle, padding = cardInsets),
onClick = onClick,
onClick = throttledClick(onClick = onClick),
enabled = isEnabled,
contentPadding = PaddingValues(
top = 10.dp,
ui/src/main/kotlin/com/bitwarden/ui/platform/components/button/BitwardenTextButton.kt
+2 -1
View File
@@ -15,6 +15,7 @@ import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.bitwarden.ui.platform.components.button.color.bitwardenTextButtonColors
import com.bitwarden.ui.platform.components.util.throttledClick
import com.bitwarden.ui.platform.theme.BitwardenTheme
/**
@@ -37,7 +38,7 @@ fun BitwardenTextButton(
) {
TextButton(
modifier = modifier.semantics(mergeDescendants = true) {},
onClick = onClick,
onClick = throttledClick(onClick = onClick),
enabled = isEnabled,
contentPadding = PaddingValues(
top = 10.dp,
ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/ThrottledClick.kt
+38
View File
@@ -0,0 +1,38 @@
package com.bitwarden.ui.platform.components.util
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
/**
* Creates a throttled click handler that prevents rapid successive clicks.
*
* @param coroutineScope The coroutine scope for launching click handlers.
* @param delayMs The minimum time in milliseconds between clicks.
* @param onClick The action to perform when clicked.
* @return A throttled click handler function.
*/
@Composable
fun throttledClick(
coroutineScope: CoroutineScope = rememberCoroutineScope(),
delayMs: Long = 300,
onClick: () -> Unit,
): () -> Unit {
var isEnabled by remember { mutableStateOf(value = true) }
return {
coroutineScope.launch {
if (isEnabled) {
isEnabled = false
onClick()
delay(timeMillis = delayMs)
isEnabled = true
}
}
}
}