e121e525ce
* Initial plan * Fix crash when switching filter from 'is' to 'one of' - Add logic to convert single values to arrays when switching to oneOf/notOneOf operators - Add comprehensive tests for the fix Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * Add type assertions to fix TypeScript errors Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * Keep first element when switching from 'one of' to 'is', use strict comparison - When switching from array operators (oneOf/notOneOf) to single-value operators (is/isNot), keep the first element instead of clearing - Use strict equality operators (=== instead of ==) - Add comprehensive tests for array-to-single conversion Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * Add release notes for PR #6491 * Fix crash due to filter value conversion issue * Address PR feedback: remove notes test, preserve single values between operators - Remove test for notes field exclusion (issue #6325 handles notes separately) - Only clear values when converting FROM arrays, not between single-value operators - Add test to verify single values are preserved when switching between single-value operators (e.g., 'is' to 'contains') Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * Update value handling in updateFilterReducer Handle value conversion for single-value operators and clear value for certain type switches. * Refactor value assignment for single-value operators * Refactor value assignment logic in updateFilterReducer Simplify the handling of value assignment for single-value operators by consolidating conditions. Ensure proper conversion between arrays and single values while maintaining type integrity. * Remove redundant array checks in updateFilterReducer tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Actual on the web
E2E tests
E2E (end-to-end) tests use Playwright. Running them requires an Actual server to be running either locally or on a remote server.
Functional
Running against the local server:
# Start the development server
yarn start
# Run against the local server (localhost:3001)
yarn e2e
Running against a remote server:
E2E_START_URL=http://my-remote-server.com yarn e2e
Visual regression
Visual regression tests (also known as screenshot tests) check that the visual appearance of the product has not regressed. Each environment has slightly different colors, fonts etc. Mac differs from Windows which differs from Linux. In order to have a stable test environment for visual comparisons - you must use a standartised docker container. This ensures that the tests are always ran in a consistent environment.
Prerequisites:
- Docker installed
Running against the local server
First start a dev instance:
HTTPS=true yarn start
or using the dev container:
HTTPS=true docker compose up --build
Note the network IP address and port the dev instance is listening on.
Next, navigate to the root of your project folder, run the standardized docker container, and launch the visual regression tests from within it.
Run via yarn:
# By default, this connects to https://localhost:3001
yarn vrt:docker
# To use a different ip and port:
yarn vrt:docker --e2e-start-url https://ip:port
# To update snapshots, use the following command:
yarn vrt:docker --e2e-start-url https://ip:port --update-snapshots
Run manually:
# Run docker container
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash
# If you receive an error such as "docker: invalid reference format", please instead use the following command:
docker run --rm --network host -v ${pwd}:/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash
# Once inside the docker container, run the VRT tests: important - they MUST be ran against a HTTPS server.
# Use the ip and port noted earlier
E2E_START_URL=https://ip:port yarn vrt
# To update snapshots, use the following command:
E2E_START_URL=https://ip:port yarn vrt --update-snapshots
Running against a remote server
You can also run the tests against a remote server by passing the URL:
Run in standardized docker container:
E2E_START_URL=https://my-remote-server.com yarn vrt:docker
# Or pass in server URL as argument
yarn vrt:docker --e2e-start-url https://my-remote-server.com
Run locally:
E2E_START_URL=https://my-remote-server.com yarn vrt