* Initial commit for concentric donut chart implementation * [autofix.ci] apply automated fixes * Update upcoming-release-notes/7038.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix coderabbit comments (Recalculated total to avoid hidden cats, remove tooltip, add proper types) * Update packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix zero total group * lint issues fix * Fix lint issues * Empty commit to retriger the process * [autofix.ci] apply automated fixes * Removed line betweeen arc and label. I beleive the view is cleaner this way. * Fixed line for outer donut * split active shape for concentric circles to avoid impacting original chart * [autofix.ci] apply automated fixes * Fixing mid point to align with mid point on inner circle * 1- make line always start inside the core circle 2- fix bug where inner circle label was showing below the outer circle * - Fixed Dashboard issue when height too low. - Rewrite of the activeShape part for simplicity. - Centralize radius calculation. - Provide differnt dimensions for compact vs standard rendering - fix mid line point to auto fix at 70% of the inner radius - More readable code * Update VRT screenshots Auto-generated by VRT workflow PR: #7038 * Fixed distance issue for arc on single ring. * [autofix.ci] apply automated fixes * Update VRT screenshots Auto-generated by VRT workflow PR: #7038 * Update packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixing Code Rabbit Comments * rerunning tests * Added Group click through passing all categories iwth a workaorund on showActivity --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Actual on the web
E2E tests
E2E (end-to-end) tests use Playwright. Running them requires an Actual server to be running either locally or on a remote server.
Functional
Running against the local server:
# Start the development server
yarn start
# Run against the local server (localhost:3001)
yarn e2e
Running against a remote server:
E2E_START_URL=http://my-remote-server.com yarn e2e
Visual regression
Visual regression tests (also known as screenshot tests) check that the visual appearance of the product has not regressed. Each environment has slightly different colors, fonts etc. Mac differs from Windows which differs from Linux. In order to have a stable test environment for visual comparisons - you must use a standartised docker container. This ensures that the tests are always ran in a consistent environment.
Prerequisites:
- Docker installed
Running against the local server
First start a dev instance:
HTTPS=true yarn start
or using the dev container:
HTTPS=true docker compose up --build
Note the network IP address and port the dev instance is listening on.
Next, navigate to the root of your project folder, run the standardized docker container, and launch the visual regression tests from within it.
Run via yarn:
# By default, this connects to https://localhost:3001
yarn vrt:docker
# To use a different ip and port:
yarn vrt:docker --e2e-start-url https://ip:port
# To update snapshots, use the following command:
yarn vrt:docker --e2e-start-url https://ip:port --update-snapshots
Run manually:
# Run docker container
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.58.2-jammy /bin/bash
# If you receive an error such as "docker: invalid reference format", please instead use the following command:
docker run --rm --network host -v ${pwd}:/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.58.2-jammy /bin/bash
# Once inside the docker container, run the VRT tests: important - they MUST be ran against a HTTPS server.
# Use the ip and port noted earlier
E2E_START_URL=https://ip:port yarn vrt
# To update snapshots, use the following command:
E2E_START_URL=https://ip:port yarn vrt --update-snapshots
Running against a remote server
You can also run the tests against a remote server by passing the URL:
Run in standardized docker container:
E2E_START_URL=https://my-remote-server.com yarn vrt:docker
# Or pass in server URL as argument
yarn vrt:docker --e2e-start-url https://my-remote-server.com
Run locally:
E2E_START_URL=https://my-remote-server.com yarn vrt