github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 11:59:55 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #2720] [Bug]: Balance not updating when syncing an investment account linked to a bank with SimpleFin #8022

New Issue
Closed
opened 2026-04-10 18:10:31 -05:00 by GiteaMirror · 9 comments
GiteaMirror commented 2026-04-10 18:10:31 -05:00
Owner
Copy Link

Originally created by @mmcc-xx on GitHub (May 6, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2720

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

I initially thought this was an enhancement request, but upon looking at the code, I think it is supposed to work already.

I have some accounts linked to banks with SimpleFin. When I sync those accounts, new transactions are retrieved but the balance does not get updated.

I think the problem is in the updateAccountBalance function in packages/loot-core/src/server/accounts/sync.ts
It calls amountToInteger(balance), but balance is an array of two objects, not a numeric.

So what db.RunQuery sees is

sql = "UPDATE accounts SET balance_current = ? WHERE id = ?", params = (2) [NaN, redacted], fetchAll = undefined

To reproduce:

  1. set up an account linked to a bank with SimpleFin. Make this an account whose balance changes without associated transactions, like a brokerage account
  2. Wait a day or so for the real balance to change
  3. Sync the account. Note that the balance does not update in Actual.
  4. Open the console for the browser and dig into the debug output. Note that the new balance was returned by SimpleFin

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 10

Originally created by @mmcc-xx on GitHub (May 6, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2720 ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? I initially thought this was an enhancement request, but upon looking at the code, I think it is supposed to work already. I have some accounts linked to banks with SimpleFin. When I sync those accounts, new transactions are retrieved but the balance does not get updated. I think the problem is in the updateAccountBalance function in packages/loot-core/src/server/accounts/sync.ts It calls amountToInteger(balance), but balance is an array of two objects, not a numeric. So what db.RunQuery sees is ``` sql = "UPDATE accounts SET balance_current = ? WHERE id = ?", params = (2) [NaN, redacted], fetchAll = undefined ``` To reproduce: 1) set up an account linked to a bank with SimpleFin. Make this an account whose balance changes without associated transactions, like a brokerage account 2) Wait a day or so for the real balance to change 3) Sync the account. Note that the balance does not update in Actual. 4) Open the console for the browser and dig into the debug output. Note that the new balance was returned by SimpleFin ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 10
GiteaMirror added the bug label 2026-04-10 18:10:31 -05:00
GiteaMirror commented 2026-04-10 18:10:32 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 6, 2024):

I think if updateAccountBalance looked something like this...

async function updateAccountBalance(id, balance) {
  await db.runQuery('UPDATE accounts SET balance_current = ? WHERE id = ?', [
    //amountToInteger(balance),
    amountToInteger(balance[0].balanceAmount.amount),
    id,
  ]);
}

... it would work correctly. At least amountToInteger returns a value with balance[0].balanceAmount.amount passed in, and it appears to be the correct current balance as an integer in cents. However, I don't know how to actually get a code change working as I know little about typescript apps.

<!-- gh-comment-id:2096983236 --> @mmcc-xx commented on GitHub (May 6, 2024): I think if updateAccountBalance looked something like this... ``` async function updateAccountBalance(id, balance) { await db.runQuery('UPDATE accounts SET balance_current = ? WHERE id = ?', [ //amountToInteger(balance), amountToInteger(balance[0].balanceAmount.amount), id, ]); } ``` ... it would work correctly. At least amountToInteger returns a value with balance[0].balanceAmount.amount passed in, and it appears to be the correct current balance as an integer in cents. However, I don't know how to actually get a code change working as I know little about typescript apps.
GiteaMirror commented 2026-04-10 18:10:32 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 6, 2024):

I got the front end running locally and was able to test my change. runQuery now sees...

sql = "UPDATE accounts SET balance_current = ? WHERE id = ?", params = (2) [<correct new balance>, redacted], fetchAll = undefined

... but the new balance is not displayed in the UI, even after refreshing.

<!-- gh-comment-id:2097095619 --> @mmcc-xx commented on GitHub (May 6, 2024): I got the front end running locally and was able to test my change. runQuery now sees... ``` sql = "UPDATE accounts SET balance_current = ? WHERE id = ?", params = (2) [<correct new balance>, redacted], fetchAll = undefined ``` ... but the new balance is not displayed in the UI, even after refreshing.
GiteaMirror commented 2026-04-10 18:10:33 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 7, 2024):

I exported the sqlite database to poke around at it... in the accounts table, there are fields for balance_current balance available and balance_limit but they are all NULL for all accounts. Are these fields not used?

<!-- gh-comment-id:2098583690 --> @mmcc-xx commented on GitHub (May 7, 2024): I exported the sqlite database to poke around at it... in the accounts table, there are fields for balance_current balance available and balance_limit but they are all NULL for all accounts. Are these fields not used?
GiteaMirror commented 2026-04-10 18:10:34 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (May 7, 2024):

The balances are controlled by the transactions in that account. You can't just update an account balance. You have to add or modify a transaction in that account for a new balance to be displayed.

<!-- gh-comment-id:2098596526 --> @shall0pass commented on GitHub (May 7, 2024): The balances are controlled by the transactions in that account. You can't just update an account balance. You have to add or modify a transaction in that account for a new balance to be displayed.
GiteaMirror commented 2026-04-10 18:10:34 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 7, 2024):

The balances are controlled by the transactions in that account. You can't just update an account balance. You have to add or modify a transaction in that account for a new balance to be displayed.

I take it then that the balance fields in the accounts table aren't used?

<!-- gh-comment-id:2098974414 --> @mmcc-xx commented on GitHub (May 7, 2024): > The balances are controlled by the transactions in that account. You can't just update an account balance. You have to add or modify a transaction in that account for a new balance to be displayed. I take it then that the balance fields in the accounts table aren't used?
GiteaMirror commented 2026-04-10 18:10:35 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (May 7, 2024):

Everywhere balance_current is used : https://github.com/search?q=repo%3Aactualbudget%2Factual%20balance_current&type=code

Everywhere balance_limit is used: https://github.com/search?q=repo%3Aactualbudget%2Factual+balance_limit&type=code

I'm assuming it's not used outside of the mock tests.

<!-- gh-comment-id:2099066928 --> @shall0pass commented on GitHub (May 7, 2024): Everywhere balance_current is used : https://github.com/search?q=repo%3Aactualbudget%2Factual%20balance_current&type=code Everywhere balance_limit is used: https://github.com/search?q=repo%3Aactualbudget%2Factual+balance_limit&type=code I'm assuming it's not used outside of the mock tests.
GiteaMirror commented 2026-04-10 18:10:35 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (May 8, 2024):

I don't think this is a bug, since that field in the db isn't used. My guess is that field was just lofty goals that have yet to go anywhere. Its fine having a feature request for this.

Any complaints to closing this issue?

<!-- gh-comment-id:2101506274 --> @youngcw commented on GitHub (May 8, 2024): I don't think this is a bug, since that field in the db isn't used. My guess is that field was just lofty goals that have yet to go anywhere. Its fine having a feature request for this. Any complaints to closing this issue?
GiteaMirror commented 2026-04-10 18:10:36 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 9, 2024):

I don't think this is a bug, since that field in the db isn't used. My guess is that field was just lofty goals that have yet to go anywhere. Its fine having a feature request for this.

Any complaints to closing this issue?

Fine with me

<!-- gh-comment-id:2102794173 --> @mmcc-xx commented on GitHub (May 9, 2024): > I don't think this is a bug, since that field in the db isn't used. My guess is that field was just lofty goals that have yet to go anywhere. Its fine having a feature request for this. > > Any complaints to closing this issue? Fine with me
GiteaMirror commented 2026-04-10 18:10:36 -05:00
Author
Owner
Copy Link

@mmcc-xx commented on GitHub (May 9, 2024):

The feature request I submitted is here: https://github.com/actualbudget/actual/issues/2718

<!-- gh-comment-id:2102797796 --> @mmcc-xx commented on GitHub (May 9, 2024): The feature request I submitted is here: https://github.com/actualbudget/actual/issues/2718
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#8022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?