github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #2264] [Bug]: Import does not properly set the account sort_order database columns #7827

New Issue
Closed
opened 2026-04-10 17:50:59 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-10 17:50:59 -05:00
Owner
Copy Link

Originally created by @joel-jeremy on GitHub (Jan 21, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2264

Verified issue does not already exist?

  • I have searched and found no existing issue

Is this related to GoCardless, Simplefin or another bank-sync provider?

  • I have checked my server logs and could not see any errors there
  • I will be attaching my server logs to this issue
  • I will be attaching my client-side (browser) logs to this issue
  • I understand that this issue will be automatically closed if insufficient information is provided

What happened?

When importing a file / creating a test budget, the created accounts will have the same sort_order value in the database. This breaks the sorting functionality.

Steps to reproduce:

  1. Import a file / Create a test budget
  2. In the accounts sidebar, drag the first account and switch it with the second account
  3. The first account goes to the bottom of the accounts

This issue does is not present when a user creates a new budget, manually adds accounts and reorders the accounts.

What error did you receive?

No response

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Chrome, Other

Operating System

Mobile Device

Originally created by @joel-jeremy on GitHub (Jan 21, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2264 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### Is this related to GoCardless, Simplefin or another bank-sync provider? - [ ] I have checked my server logs and could not see any errors there - [ ] I will be attaching my server logs to this issue - [ ] I will be attaching my client-side (browser) logs to this issue - [ ] I understand that this issue will be automatically closed if insufficient information is provided ### What happened? When importing a file / creating a test budget, the created accounts will have the same `sort_order` value in the database. This breaks the sorting functionality. Steps to reproduce: 1. Import a file / Create a test budget 2. In the accounts sidebar, drag the first account and switch it with the second account 3. The first account goes to the bottom of the accounts This issue does is not present when a user creates a new budget, manually adds accounts and reorders the accounts. ### What error did you receive? _No response_ ### Where are you hosting Actual? Fly.io ### What browsers are you seeing the problem on? Chrome, Other ### Operating System Mobile Device
GiteaMirror added the bug label 2026-04-10 17:50:59 -05:00
GiteaMirror commented 2026-04-10 17:51:01 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jan 21, 2024):

It looks like the nynab importer gives unique sort values on import. It may just be the demo that they all have the same value

<!-- gh-comment-id:1902736125 --> @youngcw commented on GitHub (Jan 21, 2024): It looks like the nynab importer gives unique sort values on import. It may just be the demo that they all have the same value
GiteaMirror commented 2026-04-10 17:51:01 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jan 24, 2024):

Ive been digging into this a bit. I haven't found out why the demo is different than a ynab import, but this function does the real work. It seems like, for some reason, that when creating a demo budget this function cant ever see that there were accounts previously made in order to properly request a higher sort_order value, so all the accounts in the demo get the same one.

packages/loot-core/src/server/db/index.ts#insert-account

<!-- gh-comment-id:1908556587 --> @youngcw commented on GitHub (Jan 24, 2024): Ive been digging into this a bit. I haven't found out why the demo is different than a ynab import, but this function does the real work. It seems like, for some reason, that when creating a demo budget this function cant ever see that there were accounts previously made in order to properly request a higher sort_order value, so all the accounts in the demo get the same one. packages/loot-core/src/server/db/index.ts#insert-account
GiteaMirror commented 2026-04-10 17:51:02 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jan 24, 2024):

I think I found the problem. Ill put in a PR

<!-- gh-comment-id:1908593890 --> @youngcw commented on GitHub (Jan 24, 2024): I think I found the problem. Ill put in a PR
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?