github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7827] [MERGED] Fix CSV import settings reset when skipping end lines #131526

New Issue
Closed
opened 2026-06-16 00:11:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-16 00:11:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7827
Author: @Hui66cs
Created: 5/13/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @MatissJanis

Base: master ← Head: fix-csv-skip-end-lines-preserve-options

📝 Commits (2)

  • 5d7030a Fix CSV import settings reset when skipping end lines
  • f933e5d Merge remote-tracking branch 'upstream/master' into fix-csv-skip-end-lines-preserve-options

📊 Changes

2 files changed (+102 additions, -29 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx (+96 -29)
➕ upcoming-release-notes/7827.md (+6 -0)

📄 Description

Description

Fixes an issue where changing Skip end lines in the CSV import modal reset the user's in-progress import settings.

Previously, changing skipEndLines triggered the CSV file to be re-parsed. The preview rows updated correctly, but the parse flow also re-applied saved/default preferences for settings such as Flip amount, field mappings, split mode, and date format. Since those preferences are only saved after import, this overwrote the user's current selections in the modal.

This change preserves the current import settings only when the same CSV file is re-parsed and the only parse option that changed is skipEndLines. Other parse option changes that may affect CSV structure, such as delimiter, header row, skip start lines, or selecting a different file, keep the existing re-initialization behavior.

Related issue(s)

Fixes #7796

Testing

  • Manually reproduced issue #7796 with a CSV file containing a trailing summary row.
  • Confirmed that changing Skip end lines from 0 to 1 removes the summary row from the preview.
  • Confirmed that Flip amount remains checked after changing Skip end lines.
  • Confirmed that manually selected field mappings remain unchanged after changing Skip end lines.
  • Confirmed that delimiter, header row, and skip start lines changes still re-parse the CSV structure as before.
  • Ran:
    • yarn exec oxfmt --check packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
    • yarn exec oxlint --type-aware packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
    • yarn workspace @actual-app/web run test ImportTransactionsModal/utils.test.ts

yarn workspace @actual-app/web run typecheck was attempted twice locally, but tsgo panicked with a nil pointer dereference before producing TypeScript diagnostics.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.03 MB ��� 14.03 MB (+1.05 kB) +0.01%
loot-core 1 5.34 MB 0%
api 2 3.92 MB → 3.97 MB (+42.32 kB) +1.05%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.03 MB → 14.03 MB (+1.05 kB) +0.01%
Changeset
File Δ Size
src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx 📈 +1.05 kB (+3.28%) 31.96 kB → 33.01 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 1.54 MB → 1.54 MB (+1.05 kB) +0.07%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.98 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.44 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.08 MB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.75 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.15 kB 0%
static/js/de.js 170.77 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 198.48 kB 0%
static/js/es.js 178.68 kB 0%
static/js/extends.js 500.96 kB 0%
static/js/fr.js 178.57 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.05 kB 0%
static/js/nl.js 106.28 kB 0%
static/js/pt-BR.js 188.43 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.46 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 297.21 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.01 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker._bwMMgjb.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.92 MB → 3.97 MB (+42.32 kB) +1.05%
Changeset
File Δ Size
node_modules/ua-parser-js/src/main/ua-parser.mjs 🆕 +41.87 kB 0 B → 41.87 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/platform.ts 🆕 +431 B 0 B → 431 B
home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts 📈 +21 B (+0.41%) 5.06 kB → 5.08 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.92 MB → 3.97 MB (+42.32 kB) +1.05%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7827 **Author:** [@Hui66cs](https://github.com/Hui66cs) **Created:** 5/13/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix-csv-skip-end-lines-preserve-options` --- ### 📝 Commits (2) - [`5d7030a`](https://github.com/actualbudget/actual/commit/5d7030aad6368a36c2b296198289c1d182274deb) Fix CSV import settings reset when skipping end lines - [`f933e5d`](https://github.com/actualbudget/actual/commit/f933e5d58da84189fd0122712fa76765a5c2f317) Merge remote-tracking branch 'upstream/master' into fix-csv-skip-end-lines-preserve-options ### 📊 Changes **2 files changed** (+102 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` (+96 -29) ➕ `upcoming-release-notes/7827.md` (+6 -0) </details> ### 📄 Description ## Description Fixes an issue where changing `Skip end lines` in the CSV import modal reset the user's in-progress import settings. Previously, changing `skipEndLines` triggered the CSV file to be re-parsed. The preview rows updated correctly, but the parse flow also re-applied saved/default preferences for settings such as `Flip amount`, field mappings, split mode, and date format. Since those preferences are only saved after import, this overwrote the user's current selections in the modal. This change preserves the current import settings only when the same CSV file is re-parsed and the only parse option that changed is `skipEndLines`. Other parse option changes that may affect CSV structure, such as delimiter, header row, skip start lines, or selecting a different file, keep the existing re-initialization behavior. ## Related issue(s) Fixes #7796 ## Testing - Manually reproduced issue #7796 with a CSV file containing a trailing summary row. - Confirmed that changing `Skip end lines` from 0 to 1 removes the summary row from the preview. - Confirmed that `Flip amount` remains checked after changing `Skip end lines`. - Confirmed that manually selected field mappings remain unchanged after changing `Skip end lines`. - Confirmed that delimiter, header row, and skip start lines changes still re-parse the CSV structure as before. - Ran: - `yarn exec oxfmt --check packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` - `yarn exec oxlint --type-aware packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` - `yarn workspace @actual-app/web run test ImportTransactionsModal/utils.test.ts` `yarn workspace @actual-app/web run typecheck` was attempted twice locally, but `tsgo` panicked with a nil pointer dereference before producing TypeScript diagnostics. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.03 MB ��� 14.03 MB (+1.05 kB) | +0.01% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.92 MB → 3.97 MB (+42.32 kB) | +1.05% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.03 MB → 14.03 MB (+1.05 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` | 📈 +1.05 kB (+3.28%) | 31.96 kB → 33.01 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.54 MB → 1.54 MB (+1.05 kB) | +0.07% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.08 MB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.75 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.15 kB | 0% static/js/de.js | 170.77 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 198.48 kB | 0% static/js/es.js | 178.68 kB | 0% static/js/extends.js | 500.96 kB | 0% static/js/fr.js | 178.57 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.05 kB | 0% static/js/nl.js | 106.28 kB | 0% static/js/pt-BR.js | 188.43 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.46 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 297.21 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.01 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker._bwMMgjb.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.92 MB → 3.97 MB (+42.32 kB) | +1.05% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/ua-parser-js/src/main/ua-parser.mjs` | 🆕 +41.87 kB | 0 B → 41.87 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/platform.ts` | 🆕 +431 B | 0 B → 431 B `home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts` | 📈 +21 B (+0.41%) | 5.06 kB → 5.08 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.92 MB → 3.97 MB (+42.32 kB) | +1.05% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-16 00:11:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#131526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?