github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1907] [Maintenance] Delete unused variables #7672

New Issue
Closed
opened 2026-04-10 17:34:34 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-10 17:34:34 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Nov 14, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1907

We currently use @typescript-eslint/no-unused-vars eslint rule which is enabled for most things. However, it is disabled for args.

The overall goal here would be to re-enable @typescript-eslint/no-unused-vars for args. Thus disallowing unuser arguments.

08c80b6f58/.eslintrc.js (L54)

Please do not do this as one-big-bang migration.

Originally created by @MatissJanis on GitHub (Nov 14, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1907 We currently use `@typescript-eslint/no-unused-vars` eslint rule which is enabled for most things. However, it is disabled for `args`. The overall goal here would be to re-enable `@typescript-eslint/no-unused-vars` for `args`. Thus disallowing unuser arguments. https://github.com/actualbudget/actual/blob/08c80b6f585eaa3237100972f0edc06e45e444d1/.eslintrc.js#L54 **Please do not do this as one-big-bang migration.**
GiteaMirror added the good first issuemaintenance labels 2026-04-10 17:34:34 -05:00
GiteaMirror commented 2026-04-10 17:34:37 -05:00
Author
Owner
Copy Link

@Sahad-09 commented on GitHub (Nov 15, 2023):

I'm working on it

<!-- gh-comment-id:1812412034 --> @Sahad-09 commented on GitHub (Nov 15, 2023): I'm working on it
GiteaMirror commented 2026-04-10 17:34:38 -05:00
Author
Owner
Copy Link

@jaas666 commented on GitHub (Nov 18, 2023):

Sorry, didn't saw earlier that @Sahad-09 was working on this. Feel free to close my PR in favor of his.

<!-- gh-comment-id:1817331202 --> @jaas666 commented on GitHub (Nov 18, 2023): Sorry, didn't saw earlier that @Sahad-09 was working on this. Feel free to close my PR in favor of his.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label good first issue maintenance
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?