github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7672] [MERGED] Fix/spending report date range save #60925

New Issue
Closed
opened 2026-05-07 03:19:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-07 03:19:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7672
Author: @Aurora-Flipped
Created: 5/1/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @youngcw

Base: master ← Head: fix/spending-report-date-range-save

📝 Commits (3)

  • 9ba4348 Fix saved spending report date range
  • 1cacb54 Add release note
  • 9342099 Merge branch 'master' into fix/spending-report-date-range-save

📊 Changes

3 files changed (+62 additions, -1 deletions)

View changed files

➕ packages/desktop-client/src/components/reports/reportRanges.test.ts (+50 -0)
📝 packages/desktop-client/src/components/reports/reportRanges.ts (+6 -1)
➕ upcoming-release-notes/7672.md (+6 -0)

📄 Description

Description

Spending reports saved their selected months, but reopened reports could ignore those saved values.

For Live Average and Budgeted modes, the saved compare month was replaced with the current month when the report was loaded. For Live Single month mode, the saved compare and compare-to months were recalculated as a sliding window instead of being restored directly.

This PR preserves the saved Spending report compare month and compare-to month when loading saved report settings.

Related issue(s)

Fixes #7648

Testing

Manually tested with a demo budget:

  1. Open Reports.
  2. Open a Spending Analysis report.
  3. Change the report mode to Average, Budgeted, and Single month.
  4. Change the selected compare month.
  5. Save the report.
  6. Return to Reports.
  7. Reopen the report and confirm the saved month selection is preserved.

Also ran:

yarn workspace @actual-app/web vitest --run src/components/reports/reportRanges.test.ts

Result:

Test Files  1 passed (1)
Tests       4 passed (4)

Checklist

  • [√] Release notes added
  • [√] No obvious regressions in affected areas
  • [√] Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 13.95 MB → 13.95 MB (+137 B) +0.00%
loot-core 1 5.27 MB 0%
api 2 3.89 MB 0%
cli 1 7.97 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 13.95 MB → 13.95 MB (+137 B) +0.00%
Changeset
File Δ Size
src/components/reports/reportRanges.ts 📈 +137 B (+3.12%) 4.28 kB → 4.42 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.22 MB → 1.22 MB (+137 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.93 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 52.52 kB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionEdit.js 189.54 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/ca.js 190.22 kB 0%
static/js/chart-theme.js 796.5 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 103.32 kB 0%
static/js/de.js 172.83 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 185.81 kB 0%
static/js/es.js 181.26 kB 0%
static/js/extends.js 518.66 kB 0%
static/js/fr.js 181.27 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 167.28 kB 0%
static/js/narrow.js 364.31 kB 0%
static/js/nb-NO.js 150.48 kB 0%
static/js/nl.js 108.23 kB 0%
static/js/pl.js 88.01 kB 0%
static/js/pt-BR.js 192.06 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.2 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 210.75 kB 0%
static/js/useFormatList.js 8.63 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 119.2 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.DiBErB6z.js 5.27 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7672 **Author:** [@Aurora-Flipped](https://github.com/Aurora-Flipped) **Created:** 5/1/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix/spending-report-date-range-save` --- ### 📝 Commits (3) - [`9ba4348`](https://github.com/actualbudget/actual/commit/9ba4348af0ef97f50e55ff292be6f1f77b28fc45) Fix saved spending report date range - [`1cacb54`](https://github.com/actualbudget/actual/commit/1cacb54d57cfed06bbd4ab2a86e92aad2e704a33) Add release note - [`9342099`](https://github.com/actualbudget/actual/commit/9342099d307cbe0fbad39132cf9daa3b0ddac370) Merge branch 'master' into fix/spending-report-date-range-save ### 📊 Changes **3 files changed** (+62 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/reports/reportRanges.test.ts` (+50 -0) 📝 `packages/desktop-client/src/components/reports/reportRanges.ts` (+6 -1) ➕ `upcoming-release-notes/7672.md` (+6 -0) </details> ### 📄 Description ## Description Spending reports saved their selected months, but reopened reports could ignore those saved values. For Live Average and Budgeted modes, the saved compare month was replaced with the current month when the report was loaded. For Live Single month mode, the saved compare and compare-to months were recalculated as a sliding window instead of being restored directly. This PR preserves the saved Spending report compare month and compare-to month when loading saved report settings. ## Related issue(s) Fixes #7648 ## Testing Manually tested with a demo budget: 1. Open Reports. 2. Open a Spending Analysis report. 3. Change the report mode to Average, Budgeted, and Single month. 4. Change the selected compare month. 5. Save the report. 6. Return to Reports. 7. Reopen the report and confirm the saved month selection is preserved. Also ran: ```sh yarn workspace @actual-app/web vitest --run src/components/reports/reportRanges.test.ts ``` Result: ```text Test Files 1 passed (1) Tests 4 passed (4) ``` ## Checklist - [√] Release notes added - [√] No obvious regressions in affected areas - [√] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 13.95 MB → 13.95 MB (+137 B) | +0.00% loot-core | 1 | 5.27 MB | 0% api | 2 | 3.89 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 13.95 MB → 13.95 MB (+137 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/reportRanges.ts` | 📈 +137 B (+3.12%) | 4.28 kB → 4.42 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.22 MB → 1.22 MB (+137 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.93 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 52.52 kB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionEdit.js | 189.54 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/ca.js | 190.22 kB | 0% static/js/chart-theme.js | 796.5 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 103.32 kB | 0% static/js/de.js | 172.83 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 185.81 kB | 0% static/js/es.js | 181.26 kB | 0% static/js/extends.js | 518.66 kB | 0% static/js/fr.js | 181.27 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 167.28 kB | 0% static/js/narrow.js | 364.31 kB | 0% static/js/nb-NO.js | 150.48 kB | 0% static/js/nl.js | 108.23 kB | 0% static/js/pl.js | 88.01 kB | 0% static/js/pt-BR.js | 192.06 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.2 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 210.75 kB | 0% static/js/useFormatList.js | 8.63 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 119.2 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DiBErB6z.js | 5.27 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-07 03:19:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#60925
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?