github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #844] [Feature] Add options/setting for first day of the week #7270

New Issue
Closed
opened 2026-04-10 17:01:40 -05:00 by GiteaMirror Ā· 8 comments
GiteaMirror commented 2026-04-10 17:01:40 -05:00
Owner
Copy Link

Originally created by @mkalamarz on GitHub (Apr 2, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/844

Verified feature request does not already exist?

  • I have searched and found no existing issue

šŸ’»

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

When selecting a date ina date-picker it is confusing that Sunday is displayed as first day of the week because in Poland it is meant to be Monday.

I found no setting to change "First day of week" to "Monday".

Describe your ideal solution to this problem

Ideal solution consists of:

  1. Adding "First day of week" option/setting under "Settings" next to the date format (as this is a date-specific setting).
  2. Saving the value as integer in the database (or wherever you store it, local storage, cache, etc.)
  3. Making the date-picker respect that setting's value

I'm not an APP dev, but as far as I could tell Actual uses Pikaday for the date-picker. In it's documentation there is a firstDay option that is meant just for that. So it should be fairly easy to implement for someone who eats React for breakfast.

Even if I'm mistaken (about Pikaday), this is such a basic setting that every single date-picker or date-specific tool shoud have it at your (dev) disposal.

PS I guess it could be dane based on user's locale but I feel like it's better to make user select it manually.

Teaching and learning

In my opinion all that's needed is to update Settings > Formatting docs page as the setting is self-explanatory and anyone needing to change it will know what it does (as in every other app).

Originally created by @mkalamarz on GitHub (Apr 2, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/844 ### Verified feature request does not already exist? - [X] I have searched and found no existing issue ### šŸ’» - [ ] Would you like to implement this feature? ### Pitch: what problem are you trying to solve? When selecting a date ina date-picker it is confusing that Sunday is displayed as first day of the week because in Poland it is meant to be Monday. I found no setting to change "First day of week" to "Monday". ### Describe your ideal solution to this problem Ideal solution consists of: 1. Adding "First day of week" option/setting under "Settings" next to the date format (as this is a date-specific setting). 2. Saving the value as integer in the database (or wherever you store it, local storage, cache, etc.) 3. Making the date-picker respect that setting's value I'm not an APP dev, but as far as I could tell Actual uses [Pikaday](https://github.com/Pikaday/Pikaday) for the date-picker. In it's documentation there is a `firstDay` option that is meant just for that. So it should be fairly easy to implement for someone who eats React for breakfast. Even if I'm mistaken (about Pikaday), this is such a basic setting that every single date-picker or date-specific tool shoud have it at your (dev) disposal. PS I guess it could be dane based on user's locale but I feel like it's better to make user select it manually. ### Teaching and learning In my opinion all that's needed is to update [Settings > Formatting docs page](https://actualbudget.github.io/docs/Getting-Started/using-actual/settings#formatting) as the setting is self-explanatory and anyone needing to change it will know what it does (as in every other app).
GiteaMirror added the feature label 2026-04-10 17:01:40 -05:00
GiteaMirror commented 2026-04-10 17:01:42 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Apr 2, 2023):

This is a good idea! Iā€™m reluctant to add another formatting option here since IMO the best option would be to have the calendar match the current user locale. However, a quick look through the Intl API (and some frustrating conversations with chatgpt) suggest thereā€™s no easy way to extract the appropriate first day of the week for the userā€™s locale.

<!-- gh-comment-id:1493421988 --> @j-f1 commented on GitHub (Apr 2, 2023): This is a good idea! Iā€™m reluctant to add another formatting option here since IMO the best option would be to have the calendar match the current user locale. However, a quick look through the `Intl` API (and some frustrating conversations with chatgpt) suggest thereā€™s no easy way to extract the appropriate first day of the week for the userā€™s locale.
GiteaMirror commented 2026-04-10 17:01:43 -05:00
Author
Owner
Copy Link

@rich-howell commented on GitHub (Apr 2, 2023):

This is a good idea! Iā€™m reluctant to add another formatting option here since IMO the best option would be to have the calendar match the current user locale. However, a quick look through the Intl API (and some frustrating conversations with chatgpt) suggest thereā€™s no easy way to extract the appropriate first day of the week for the userā€™s locale.

Could you get the current day of the users locale and calculate the beginning of the week from there if there is nothing available within the API?

<!-- gh-comment-id:1493424724 --> @rich-howell commented on GitHub (Apr 2, 2023): > This is a good idea! Iā€™m reluctant to add another formatting option here since IMO the best option would be to have the calendar match the current user locale. However, a quick look through the `Intl` API (and some frustrating conversations with chatgpt) suggest thereā€™s no easy way to extract the appropriate first day of the week for the userā€™s locale. Could you get the current day of the users locale and calculate the beginning of the week from there if there is nothing available within the API?
GiteaMirror commented 2026-04-10 17:01:44 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Apr 2, 2023):

Looks like date-fns has the necessary info!

<!-- gh-comment-id:1493429213 --> @j-f1 commented on GitHub (Apr 2, 2023): Looks like `date-fns` has the necessary info!
GiteaMirror commented 2026-04-10 17:01:46 -05:00
Author
Owner
Copy Link

@biohzrddd commented on GitHub (Apr 16, 2023):

What about changing the "New File" workflow to have a single "Setup" screen where the user is shown all the settings that will be used? They can name the file, then change any default settings before hitting "Create".

If this is accepted by most, I could mock something up. It would be good to reuse the current Settings function though I may need help understanding if the settings are global to all files or per-file. If the settings aren't per-file, that may need to be a separate issue before attacking this.

<!-- gh-comment-id:1510198023 --> @biohzrddd commented on GitHub (Apr 16, 2023): What about changing the "New File" workflow to have a single "Setup" screen where the user is shown all the settings that will be used? They can name the file, then change any default settings before hitting "Create". If this is accepted by most, I could mock something up. It would be good to reuse the current Settings function though I may need help understanding if the settings are global to all files or per-file. If the settings aren't per-file, that may need to be a separate issue before attacking this.
GiteaMirror commented 2026-04-10 17:01:46 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Apr 16, 2023):

What about changing the "New File" workflow to have a single "Setup" screen where the user is shown all the settings that will be used? They can name the file, then change any default settings before hitting "Create".

I like that the current workflow puts you right into getting your budget set up without asking a bunch of questions (hence Iā€™d prefer an automatic option that checks based on the current locale for the most natural experience.

If the settings aren't per-file, that may need to be a separate issue before attacking this.

fyi: all the settings in the web app are per-file (the electron app also has a setting about where to put its files on disk which is global)

<!-- gh-comment-id:1510306199 --> @j-f1 commented on GitHub (Apr 16, 2023): > What about changing the "New File" workflow to have a single "Setup" screen where the user is shown all the settings that will be used? They can name the file, then change any default settings before hitting "Create". I like that the current workflow puts you right into getting your budget set up without asking a bunch of questions (hence Iā€™d prefer an automatic option that checks based on the current locale for the most natural experience. > If the settings aren't per-file, that may need to be a separate issue before attacking this. fyi: all the settings in the web app are per-file (the electron app also has a setting about where to put its files on disk which is global)
GiteaMirror commented 2026-04-10 17:01:47 -05:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 1, 2023):

āœØ Thanks for sharing your idea! āœØ

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open. This doesnā€™t mean we donā€™t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).

The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=is%3Aissue+label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc

Donā€™t forget to upvote the top comment with šŸ‘!

<!-- gh-comment-id:1530112134 --> @github-actions[bot] commented on GitHub (May 1, 2023): :sparkles: Thanks for sharing your idea! :sparkles: This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open. This doesnā€™t mean we donā€™t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution). The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=is%3Aissue+label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc Donā€™t forget to upvote the top comment with šŸ‘!
GiteaMirror commented 2026-04-10 17:01:47 -05:00
Author
Owner
Copy Link

@mkalamarz commented on GitHub (May 5, 2023):

@MatissJanis as this got implemented in 23.5.0, shouldn't there be an "Implemented" tag or some kind of bot/human notice here? I'm not sure how in this new "feature requests get closed" setup should we distinguish "closed but please vote" from "closed but in development" and "closed and implemented" etc.

<!-- gh-comment-id:1536249443 --> @mkalamarz commented on GitHub (May 5, 2023): @MatissJanis as this got implemented in 23.5.0, shouldn't there be an "Implemented" tag or some kind of bot/human notice here? I'm not sure how in this new "feature requests get closed" setup should we distinguish "closed but please vote" from "closed but in development" and "closed and implemented" etc.
GiteaMirror commented 2026-04-10 17:01:48 -05:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (May 5, 2023):

That would be great to have automated!

  • Remove the ā€œneeds votesā€ and ā€œhelp wantedā€ and ā€œgood first issueā€ labels
  • Collapse the automated comment as outdated
  • Maybe post a new comment when the release hits?
<!-- gh-comment-id:1536254401 --> @j-f1 commented on GitHub (May 5, 2023): That would be great to have automated! - Remove the ā€œneeds votesā€ and ā€œhelp wantedā€ and ā€œgood first issueā€ labels - Collapse the automated comment as outdated - Maybe post a new comment when the release hits?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
canā€™t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
āœØ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
āœ… approved
wontfix
No Label feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7270
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?