mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[GH-ISSUE #773] [Feedback] New autocomplete #70041
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#70041
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @j-f1 on GitHub (Mar 17, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/773
Originally assigned to: @MatissJanis on GitHub.
Introduced in #741.
Remaining bugs/tasks (comment below to add to the list!)
Autocomplete:
not sure the “x” button provides much value and it is super weird (it acts on mouse down + delay rather than mouse up), maybe it can be removed?When scrolling the focused row out of view it (sometimes) suddenly jumps back into view. The old component gracefully drops focus and picks it up when scrolled back into viewglobal undo/redo don’t work when focused on a text fieldPayeeAutocomplete:
GenericInput:
When the field is freeform, the suggestion menu shouldn’t appear? (maybe)Components that use the old autocomplete:
@MatissJanis commented on GitHub (Mar 17, 2023):
I expanded the scope of this issue to be the full migration to the new autocomplete component. Not just PayeeAutocomplete.
Hope you don't mind.
@MatissJanis commented on GitHub (Mar 18, 2023):
I actually view the "x" button more as a feature, not a bug. It's a convenient way to clear the autocomplete selection.
@MatissJanis commented on GitHub (Mar 19, 2023):
Could you elaborate on this one?
@j-f1 commented on GitHub (Mar 19, 2023):
Sure!
Expected behavior: undoes the deletion. Actual behavior: nothing (compare with handling of old autocomplete)
@albertogasparin commented on GitHub (Mar 24, 2023):
[RESOLVED]
Have another bug - request for the new autocomplete: allow the dropdown to have a min width, expanding past the input. Reason being when viewing the table on narrow screens (eg iPad) the dropdown is so small that each row wraps into 3, making it hard to scroll/select.
@MatissJanis commented on GitHub (Mar 31, 2023):
@albertogasparin good idea: #834
@MatissJanis commented on GitHub (Mar 31, 2023):
Ok, looked more into this. It's interesting..
Yes, the old autocomplete allowed global "ctrl+z" operation. But judging by this code - it was actually a bug. Since we explicitly capture undo events that happen in input boxes. I presume it's so the "undo" would apply only to the local input box and would not affect the global state.
With the new autocomplete this bug is fixed. Which means we are no longer able to do global undo operation if the autocomplete field is focused.
Given all this: I think this issue is a wont-fix. WDYT?
@j-f1 commented on GitHub (Mar 31, 2023):
That’s reasonable.
@MatissJanis commented on GitHub (Mar 31, 2023):
@j-f1 I don't recall what was this one. Can you jog my memory?
@j-f1 commented on GitHub (Mar 31, 2023):
When you filter by Notes → “one of” you get this UI. I think that line was about potentially getting rid of the “Add ‘test’” popup but I’m not sure if it’s a good idea.
@MatissJanis commented on GitHub (Apr 1, 2023):
Managed to reproduce it, but it also happens in the old autocomplete (see demo below). Basically it has to do with how the table virtualizes and animates the rows outside of the viewport.. When a row is moved outside of the viewport - the row (including autocomplete) is unmounted. And then re-mounted again. Which causes this flash.
IMO this will be addressed once we get to the table migration. As for the autocomplete: I would put this as out-of-scope. WDYT?
https://user-images.githubusercontent.com/886567/229308099-320b111c-297a-4fe7-97a1-9777192039bc.mov
@j-f1 commented on GitHub (Apr 1, 2023):
Sure, fine with me!
@j-f1 commented on GitHub (Apr 6, 2023):
[RESOLVED]
New issue: the autocomplete is a different height than regular inputs. This is mainly noticeable in the rule editor, where the condition/action rows change height when switching between e.g.
payee isanddate isandnotes is@rich-howell commented on GitHub (Apr 7, 2023):
When adding a transaction to the transaction table, generally I will type my Payee Name E.G. Cambrian Heritage Railways there is sometimes already a Payee with that name in the list but for some reason I am presented with the following dropdown
There is only one of the Payee in the list, it is an exact match, that should be selected, not sure why I am presented with the option to create the Payee with a name that distinctly already exists.
I am sure it didn't used to be like this ....
@jnv commented on GitHub (Apr 12, 2023):
Hi, since I've updated to the April version of Actual, the new autocomplete in category select causes breaks my keyboard-centered workflow when entering a transaction.
My workflow used to be following:
At this point Category is usually populated either from payee or note.
Now with the new Autocomplete component, there's a problem in Step 5: If the category is populated by Note, moving focus to the Category pre-selects Split Transaction, so hitting Tab creates a split transaction. To my knowledge, there's no way to turn a split transaction back to a regular transaction, so I need to cancel the transaction and start a new one.
This issue doesn't happen when the category gets selected by Payee, so I think it has to do with delay in rule evaluation (when the category select gets focused before the category is automatically selected).
I recorded the problem to better illustrate my point:
Screencast from 2023-04-12 12-41-13.webm
@j-f1 commented on GitHub (Apr 12, 2023):
You should be able to hit ctrl/cmd+Z to undo! But I agree this should be fixed.
@jnv commented on GitHub (Apr 12, 2023):
That was my thinking exactly. Undo works for removing an added transaction, but doesn't work for changing an uncommitted split transaction back to a regular one.
@pcchristie commented on GitHub (Apr 15, 2023):
I am having @jnv 's issue but also another similar but different one. I used to start at the bottom of my recently imported transactions and shift+tab back through the transactions until I get to the top.
When I am entering a category, let's say "Food" I would previously type "Fo" and food would suggest autocomplete. At that point I should shift+tab (or tab) past it and it should fill. Instead, it removes my input and restores the category to blank. I swear it used to work "properly." Has anyone else noticed this?
It works well with Enter, but not with tab anymore.
@MatissJanis commented on GitHub (Apr 16, 2023):
Both of the last two reported issues also relate to
react-selectnot allowing us to natively control the "active"/"hovered" element. I'll see if there's any workaround here..https://github.com/actualbudget/actual/issues/773#issuecomment-1505058502 & https://github.com/actualbudget/actual/issues/773#issuecomment-1509440297
@MatissJanis commented on GitHub (Apr 18, 2023):
👋 Calling off the new-autocomplete (react-select) experiment as a failure. Reverting back to previous autocomplete and fixing some things in the old one.
We might sometime in the future consider other alternatives. But clearly
react-selectis not exactly what we want. It has too many limitations that are tricky to work around.https://github.com/actualbudget/actual/pull/916