github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6971] [WIP] Fix: new categories always rejected as duplicates #6854

New Issue
Closed
opened 2026-02-28 21:33:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:33:37 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6971

State: closed
Merged: No

Summary

  • Fixed a bug in useSaveCategoryMutation where creating a new category in a group that already contains categories always triggers the "already exists" error, regardless of the name entered
  • The duplicate name check was unconditionally returning true for new categories (id === 'new') instead of comparing names
  • Now properly checks if the name actually matches an existing category before rejecting

Before

const exists = categoriesInGroup.some(c =>
  category.id === 'new'
    ? true  // always returns true — any existing category = "duplicate"
    : c.id !== category.id &&
      c.name.toUpperCase() === category.name.toUpperCase(),
);

After

const exists = categoriesInGroup.some(
  c =>
    (category.id === 'new' || c.id !== category.id) &&
    c.name.toUpperCase() === category.name.toUpperCase(),
);

Test plan

  • Create a new budget with default categories
  • Try adding a new category (e.g., "Pluto") to any existing group → previously failed with "already exists", now works correctly
  • Verify that actual duplicate names are still rejected
  • Verify renaming a category to a name that already exists in the group is still rejected

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6971 **State:** closed **Merged:** No --- ## Summary - Fixed a bug in `useSaveCategoryMutation` where creating a new category in a group that already contains categories always triggers the "already exists" error, regardless of the name entered - The duplicate name check was unconditionally returning `true` for new categories (`id === 'new'`) instead of comparing names - Now properly checks if the name actually matches an existing category before rejecting ## Before ```js const exists = categoriesInGroup.some(c => category.id === 'new' ? true // always returns true — any existing category = "duplicate" : c.id !== category.id && c.name.toUpperCase() === category.name.toUpperCase(), ); ``` ## After ```js const exists = categoriesInGroup.some( c => (category.id === 'new' || c.id !== category.id) && c.name.toUpperCase() === category.name.toUpperCase(), ); ``` ## Test plan - [x] Create a new budget with default categories - [x] Try adding a new category (e.g., "Pluto") to any existing group → previously failed with "already exists", now works correctly - [x] Verify that actual duplicate names are still rejected - [x] Verify renaming a category to a name that already exists in the group is still rejected 🤖 Generated with [Claude Code](https://claude.com/claude-code)
GiteaMirror added the pull-request label 2026-02-28 21:33:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?