github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6966] [MERGED] Prevent single-slash paths from being parsed as filepaths #21213

New Issue
Closed
opened 2026-04-14 21:57:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:57:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6966
Author: @PratikSilwal5
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @matt-fidd

Base: master ← Head: fix-filepath-bug

📝 Commits (5)

  • ae654d3 fix: prevent single-slash paths from being parsed as filepaths
  • d2cc313 add release notes
  • da8d6d0 [autofix.ci] apply automated fixes
  • d6194de test: add tests related to filepath
  • e666246 additonal test from coderabbit

📊 Changes

3 files changed (+95 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/notes/linkParser.test.ts (+88 -0)
📝 packages/desktop-client/src/notes/linkParser.ts (+1 -1)
➕ upcoming-release-notes/6966.md (+6 -0)

📄 Description

Fixes #6854

The previous UNIX_PATH_REGEX pattern matched any string starting with '/' followed by one or more path segments. This caused simple words like '/transaction' or '/word' in transaction notes to be incorrectly parsed as file paths and rendered as clickable buttons.

This change updates the regex to require at least two path segments (e.g., '/usr/bin' or '/home/user/file.txt'), preventing single-segment paths like '/word' from being treated as filepaths.

Changes:

  • Updated UNIX_PATH_REGEX from /^\/(?:[^\s\/]+\/)*[^\s\/]+$/ to /^\/[^\s\/]+\/[^\s]*$/
  • New pattern requires: start with '/', at least one non-whitespace/non-slash segment, another '/', then any non-whitespace characters
  • This prevents '/word' from matching while still allowing legitimate paths like '/usr/bin' or '/home/user/file.txt'

Result:
Words like '/transaction' in notes will now display as regular text instead of being converted to underlined, pink button elements.

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.65 MB → 14.65 MB (-6 B) -0.00%
loot-core 1 5.86 MB 0%
api 1 4.4 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.65 MB → 14.65 MB (-6 B) -0.00%
Changeset
File Δ Size
src/notes/linkParser.ts 📉 -6 B (-0.14%) 4.26 kB → 4.25 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 9.49 MB → 9.49 MB (-6 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 180.44 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 164.99 kB 0%
static/js/es.js 173.83 kB 0%
static/js/fr.js 179.97 kB 0%
static/js/it.js 171.44 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 154.57 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.13 MB 0%
static/js/narrow.js 638.5 kB 0%
static/js/TransactionList.js 106.13 kB 0%
static/js/wide.js 164.05 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 10.05 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.86 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.hYlRL2CV.js 5.86 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.4 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.4 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6966 **Author:** [@PratikSilwal5](https://github.com/PratikSilwal5) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix-filepath-bug` --- ### 📝 Commits (5) - [`ae654d3`](https://github.com/actualbudget/actual/commit/ae654d35fcd43cbb5890e177918d814ced9dd07b) fix: prevent single-slash paths from being parsed as filepaths - [`d2cc313`](https://github.com/actualbudget/actual/commit/d2cc313044777cf911f3e6a048d3513ac27b5e05) add release notes - [`da8d6d0`](https://github.com/actualbudget/actual/commit/da8d6d094683b6526b1fe702d24157ce7a41903f) [autofix.ci] apply automated fixes - [`d6194de`](https://github.com/actualbudget/actual/commit/d6194deac988ff667e1bb8750eccc20c30aff408) test: add tests related to filepath - [`e666246`](https://github.com/actualbudget/actual/commit/e6662469941fa7d59ded0456259195a7737e2f5f) additonal test from coderabbit ### 📊 Changes **3 files changed** (+95 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/notes/linkParser.test.ts` (+88 -0) 📝 `packages/desktop-client/src/notes/linkParser.ts` (+1 -1) ➕ `upcoming-release-notes/6966.md` (+6 -0) </details> ### 📄 Description Fixes #6854 The previous UNIX_PATH_REGEX pattern matched any string starting with '/' followed by one or more path segments. This caused simple words like '/transaction' or '/word' in transaction notes to be incorrectly parsed as file paths and rendered as clickable buttons. This change updates the regex to require at least two path segments (e.g., '/usr/bin' or '/home/user/file.txt'), preventing single-segment paths like '/word' from being treated as filepaths. **Changes:** - Updated UNIX_PATH_REGEX from `/^\/(?:[^\s\/]+\/)*[^\s\/]+$/` to `/^\/[^\s\/]+\/[^\s]*$/` - New pattern requires: start with '/', at least one non-whitespace/non-slash segment, another '/', then any non-whitespace characters - This prevents '/word' from matching while still allowing legitimate paths like '/usr/bin' or '/home/user/file.txt' **Result:** Words like '/transaction' in notes will now display as regular text instead of being converted to underlined, pink button elements. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.65 MB → 14.65 MB (-6 B) | -0.00% loot-core | 1 | 5.86 MB | 0% api | 1 | 4.4 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.65 MB → 14.65 MB (-6 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/notes/linkParser.ts` | 📉 -6 B (-0.14%) | 4.26 kB → 4.25 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.49 MB → 9.49 MB (-6 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 180.44 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 164.99 kB | 0% static/js/es.js | 173.83 kB | 0% static/js/fr.js | 179.97 kB | 0% static/js/it.js | 171.44 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 154.57 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.13 MB | 0% static/js/narrow.js | 638.5 kB | 0% static/js/TransactionList.js | 106.13 kB | 0% static/js/wide.js | 164.05 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 10.05 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.86 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.hYlRL2CV.js | 5.86 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.4 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.4 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:57:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#21213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?