github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-21 06:31:58 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #6596] Rename serverPrefs state slice property to server #6625

New Issue
Closed
opened 2026-02-28 21:30:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:30:49 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6596

State: closed
Merged: Yes

Addresses feedback from #6234 to rename the serverPrefs property in the PrefsState to server for consistency with other preference properties (local, global, synced).

Changes

  • PrefsState type: serverPrefs: ServerPrefs → server: ServerPrefs
  • Reducers: Updated mergeServerPrefs, resetApp, and getUserData.fulfilled to reference state.server
  • useServerPref hook: Selector changed from state.prefs.serverPrefs[prefName] to state.prefs.server[prefName]
// Before
type PrefsState = {
  local: MetadataPrefs;
  global: GlobalPrefs;
  synced: SyncedPrefs;
  serverPrefs: ServerPrefs;  // ❌ Inconsistent naming
};

// After
type PrefsState = {
  local: MetadataPrefs;
  global: GlobalPrefs;
  synced: SyncedPrefs;
  server: ServerPrefs;  // ✅ Follows existing pattern
};

Backend API continues to use serverPrefs as the variable name when extracting from response payloads, maintaining compatibility with the server contract.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6596 **State:** closed **Merged:** Yes --- Addresses feedback from #6234 to rename the `serverPrefs` property in the PrefsState to `server` for consistency with other preference properties (`local`, `global`, `synced`). ## Changes - **PrefsState type**: `serverPrefs: ServerPrefs` → `server: ServerPrefs` - **Reducers**: Updated `mergeServerPrefs`, `resetApp`, and `getUserData.fulfilled` to reference `state.server` - **useServerPref hook**: Selector changed from `state.prefs.serverPrefs[prefName]` to `state.prefs.server[prefName]` ```typescript // Before type PrefsState = { local: MetadataPrefs; global: GlobalPrefs; synced: SyncedPrefs; serverPrefs: ServerPrefs; // ❌ Inconsistent naming }; // After type PrefsState = { local: MetadataPrefs; global: GlobalPrefs; synced: SyncedPrefs; server: ServerPrefs; // ✅ Follows existing pattern }; ``` Backend API continues to use `serverPrefs` as the variable name when extracting from response payloads, maintaining compatibility with the server contract. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
GiteaMirror added the pull-request label 2026-02-28 21:30:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6625
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?