[PR #6552] Fix/saved filters position #6596

New Issue

2026-02-28T21:30:29-06:00

GiteaMirror commented

2026-02-28 21:30:29 -06:00

Original Pull Request: https://github.com/actualbudget/actual/pull/6552

State: closed
Merged: Yes

Summary

Fixes #6535

This PR moves the "saved filters" option to the end of the filters dropdown menu and adds a separator to distinguish it from regular filter options.

Changes

Reorganized filter menu items to place 'saved filters' at the end
Added separator before 'saved filters' to distinguish from regular filters
Maintained alphabetical sorting for regular filter options

Implementation Details

The solution uses a custom sort function in the Menu component that:

Places 'saved' field at the end of the list
Keeps regular filters alphabetically sorted
Adds a separator item between regular and saved filters

Testing

Local testing: Unable to test due to environment setup issues
Will test on Netlify preview deployment once available
Expected behavior:
- "Saved filters" appears at the end of dropdown
- Visual separator before "Saved filters"
- Other filters remain alphabetically sorted
- All filter functionality works correctly

Screenshots

Summary by CodeRabbit

Bug Fixes
- Moved saved filters to the end of the filter dropdown and added a non-interactive divider to separate them.
- Preserved alphabetical sorting within each group so items remain ordered.
- Saved filters remain selectable after the divider.
Documentation
- Added a release-note entry documenting this bug fix.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6552 **State:** closed **Merged:** Yes --- ## Summary Fixes #6535 This PR moves the "saved filters" option to the end of the filters dropdown menu and adds a separator to distinguish it from regular filter options. ## Changes - Reorganized filter menu items to place 'saved filters' at the end - Added separator before 'saved filters' to distinguish from regular filters - Maintained alphabetical sorting for regular filter options ## Implementation Details The solution uses a custom sort function in the Menu component that: 1. Places 'saved' field at the end of the list 2. Keeps regular filters alphabetically sorted 3. Adds a separator item between regular and saved filters ## Testing - [x] Local testing: Unable to test due to environment setup issues - [x] Will test on Netlify preview deployment once available - [x] Expected behavior: - "Saved filters" appears at the end of dropdown - Visual separator before "Saved filters" - Other filters remain alphabetically sorted - All filter functionality works correctly ## Screenshots <img width="105" height="409" alt="Screenshot 2026-01-05 at 09 36 41" src="https://github.com/user-attachments/assets/5ae7c752-8835-46a1-8cde-524a266a9676" />  ## Summary by CodeRabbit * **Bug Fixes** * Moved saved filters to the end of the filter dropdown and added a non-interactive divider to separate them. * Preserved alphabetical sorting within each group so items remain ordered. * Saved filters remain selectable after the divider. * **Documentation** * Added a release-note entry documenting this bug fix. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

GiteaMirror added the pull-request label 2026-02-28 21:30:29 -06:00

GiteaMirror closed this issue