github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6428] refactor: replace eslint-plugin-import with eslint-plugin-perfectionist for import sorting #6516

New Issue
Closed
opened 2026-02-28 21:29:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:29:27 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6428

State: closed
Merged: Yes

why replace the plugin?

oxlint/oxfmt uses eslint-plugin-perfectionist, but it does not yet expose customGroups config option. So we can't swap to using oxc yet.. but we can prepare the way

why remove extension rule?

that's the only remaining import eslint rule and it's taking by far the most time (> 25%). Thus removing it saves us some time + we get rid of the extra dependency. IMO that's a good trade-off.

oxlint also has this rule, but it does not match the eslint one and reports a lot of false negative issues.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6428 **State:** closed **Merged:** Yes --- **why replace the plugin?** oxlint/oxfmt uses `eslint-plugin-perfectionist`, but it does not yet expose `customGroups` config option. So we can't swap to using oxc yet.. but we can prepare the way **why remove extension rule?** that's the only remaining `import` eslint rule and it's taking by far the most time (> 25%). Thus removing it saves us some time + we get rid of the extra dependency. IMO that's a good trade-off. `oxlint` also has this rule, but it does not match the eslint one and reports a lot of false negative issues.
GiteaMirror added the pull-request label 2026-02-28 21:29:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?