github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5486] [MERGED] Fix translate custom report and rule #5959

New Issue
Closed
opened 2026-02-28 21:21:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:21:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5486
Author: @milanalexandre
Created: 8/5/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @joel-jeremy

Base: master ← Head: fix/translate_custom-report_and_rule-config

📝 Commits (9)

  • 517b655 translate Allocation Methods
  • 6c21027 fix translate Action
  • acbf6eb translate date range
  • f641f0f translate monthly spending
  • d3e7f11 translate shorter filter
  • e3a9958 translate date filter reports custom
  • 5a03ee9 Merge branch 'fix/translate-cutom-report' into fix/translate_custom-report_and_rule-config
  • 866c2d3 Merge branch 'fix/translate-rule-config' into fix/translate_custom-report_and_rule-config
  • f014f68 add relese note

📊 Changes

9 files changed (+51 additions, -30 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditRuleModal.jsx (+25 -18)
📝 packages/desktop-client/src/components/reports/DateRange.tsx (+3 -2)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+5 -0)
📝 packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx (+1 -1)
📝 packages/desktop-client/src/components/rules/ActionExpression.tsx (+2 -2)
📝 packages/desktop-client/src/components/rules/RuleRow.tsx (+1 -1)
📝 packages/desktop-client/src/components/rules/Value.tsx (+1 -1)
📝 packages/loot-core/src/shared/rules.ts (+7 -5)
➕ upcoming-release-notes/5486.md (+6 -0)

📄 Description

Context

The UI elements for custom reports and rule configurations were not displaying correctly due to missing or improperly applied translations.

Summary of Changes

Rule Configuration:

  • Replaced static ALLOCATION_METHODS with a dynamic getAllocationMethods function and translated its values.
  • Updated actionFields and splitActionFields to use dynamic functions (getActionFields and getSplitActionFields). ( Fixes #5466 )
  • Added translations for "Apply to all" / "Split xx" on the Rules page.

Custom Reports Enhancements:

  • Added translations for date input fields in the Custom Report edit view.
  • Added translations for "this month" / "all time" on the Reports page.
  • Added translations for "budgeted" and "average" on the monthly spending card.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5486 **Author:** [@milanalexandre](https://github.com/milanalexandre) **Created:** 8/5/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `fix/translate_custom-report_and_rule-config` --- ### 📝 Commits (9) - [`517b655`](https://github.com/actualbudget/actual/commit/517b655a263a2f3edb02f5e1389656e9c519ef27) translate Allocation Methods - [`6c21027`](https://github.com/actualbudget/actual/commit/6c21027f8b54b9cf7a3fabd6c6ce7b120205eeb7) fix translate Action - [`acbf6eb`](https://github.com/actualbudget/actual/commit/acbf6ebdd851785bd93a0856fab06f18d0dac943) translate date range - [`f641f0f`](https://github.com/actualbudget/actual/commit/f641f0f9afcc971f799fcad70ae1cf9b57939ebf) translate monthly spending - [`d3e7f11`](https://github.com/actualbudget/actual/commit/d3e7f11ba65b5ccb30a220cca4fd431e74cd6c15) translate shorter filter - [`e3a9958`](https://github.com/actualbudget/actual/commit/e3a9958c07ae154dd44c3075081ea097cfd8dfc9) translate date filter reports custom - [`5a03ee9`](https://github.com/actualbudget/actual/commit/5a03ee96148cb204a3ea535a58244fa2745e8752) Merge branch 'fix/translate-cutom-report' into fix/translate_custom-report_and_rule-config - [`866c2d3`](https://github.com/actualbudget/actual/commit/866c2d30e385c7b9768ecc3edee054971906e9e8) Merge branch 'fix/translate-rule-config' into fix/translate_custom-report_and_rule-config - [`f014f68`](https://github.com/actualbudget/actual/commit/f014f6860b6f93f02e91c663ea69e5df5f7746b7) add relese note ### 📊 Changes **9 files changed** (+51 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditRuleModal.jsx` (+25 -18) 📝 `packages/desktop-client/src/components/reports/DateRange.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+5 -0) 📝 `packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/rules/ActionExpression.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/rules/RuleRow.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/rules/Value.tsx` (+1 -1) 📝 `packages/loot-core/src/shared/rules.ts` (+7 -5) ➕ `upcoming-release-notes/5486.md` (+6 -0) </details> ### 📄 Description ## Context The UI elements for custom reports and rule configurations were not displaying correctly due to missing or improperly applied translations. ## Summary of Changes ### **Rule Configuration**: - Replaced static `ALLOCATION_METHODS` with a dynamic `getAllocationMethods` function and translated its values. - Updated `actionFields` and `splitActionFields` to use dynamic functions (`getActionFields` and `getSplitActionFields`). ( Fixes #5466 ) - Added translations for "Apply to all" / "Split xx" on the Rules page. ### **Custom Reports Enhancements**: - Added translations for date input fields in the Custom Report edit view. - Added translations for "this month" / "all time" on the Reports page. - Added translations for "budgeted" and "average" on the monthly spending card. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:21:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?