github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 12:59:01 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #5959] [CLOSED] Fix update-vrt-apply ci job dispatch #24844

New Issue
Closed
opened 2026-04-16 18:15:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:15:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5959
Author: @MatissJanis
Created: 10/18/2025
Status: ❌ Closed

Base: master ← Head: cursor/fix-update-vrt-apply-ci-job-dispatch-b324

📝 Commits (2)

  • 5771000 Add CI checks to VRT update workflow
  • 9af9dc8 feat: Trigger CI on VRT update and checkout PR branch

📊 Changes

3 files changed (+66 additions, -2 deletions)

View changed files

📝 .github/workflows/build.yml (+18 -0)
📝 .github/workflows/check.yml (+23 -1)
📝 .github/workflows/vrt-update-apply.yml (+25 -1)

📄 Description

Problem

The update-vrt-apply workflow, which automatically updates VRT screenshots on a contributor's fork, currently doesn't trigger standard CI checks (lint, typecheck, test). This means VRT updates could potentially introduce issues without being caught by CI.

Solution

This PR integrates the core CI checks (yarn lint, yarn typecheck, yarn test) directly into the update-vrt-apply workflow. These checks will now run immediately after VRT changes are applied and pushed to the fork.

Why

Our main CI workflows are configured to run only on pushes to the master branch or on pull request events, not on pushes to fork branches. By running checks directly in the VRT workflow, we ensure all VRT updates are validated against our code quality standards, providing immediate feedback and preventing regressions. This approach also avoids the complexities and permission issues of trying to trigger CI on a fork repository.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5959 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/18/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cursor/fix-update-vrt-apply-ci-job-dispatch-b324` --- ### 📝 Commits (2) - [`5771000`](https://github.com/actualbudget/actual/commit/57710006e0b4172b4bc78bfaeb3964a64a012c62) Add CI checks to VRT update workflow - [`9af9dc8`](https://github.com/actualbudget/actual/commit/9af9dc84e908cd03dd7550b4fffded6896864565) feat: Trigger CI on VRT update and checkout PR branch ### 📊 Changes **3 files changed** (+66 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+18 -0) 📝 `.github/workflows/check.yml` (+23 -1) 📝 `.github/workflows/vrt-update-apply.yml` (+25 -1) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release:notes *before* pushing your PR for an interactive experience. --> ### Problem The `update-vrt-apply` workflow, which automatically updates VRT screenshots on a contributor's fork, currently doesn't trigger standard CI checks (lint, typecheck, test). This means VRT updates could potentially introduce issues without being caught by CI. ### Solution This PR integrates the core CI checks (`yarn lint`, `yarn typecheck`, `yarn test`) directly into the `update-vrt-apply` workflow. These checks will now run immediately after VRT changes are applied and pushed to the fork. ### Why Our main CI workflows are configured to run only on pushes to the `master` branch or on pull request events, not on pushes to fork branches. By running checks directly in the VRT workflow, we ensure all VRT updates are validated against our code quality standards, providing immediate feedback and preventing regressions. This approach also avoids the complexities and permission issues of trying to trigger CI on a fork repository. --- <a href="https://cursor.com/background-agent?bcId=bc-608c9864-3fa3-4d06-b8a9-9ec51010680d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-608c9864-3fa3-4d06-b8a9-9ec51010680d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:15:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?