github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3941] [MERGED] Fix issue where the UI is stuck sync'ing if no data from server #5128

New Issue
Closed
opened 2026-02-28 21:06:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:06:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3941
Author: @psybers
Created: 12/8/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @matt-fidd

Base: master ← Head: sync_nodata

📝 Commits (5)

  • ff39105 Fix issue where the UI is stuck sync'ing if no data from server
  • b502e4b add release note
  • 2f4baf2 Merge branch 'master' into sync_nodata
  • c30edc7 Merge branch 'master' into sync_nodata
  • 8fbb13c Merge branch 'master' into sync_nodata

📊 Changes

3 files changed (+61 additions, -36 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.ts (+3 -0)
📝 packages/loot-core/src/server/main.ts (+52 -36)
➕ upcoming-release-notes/3941.md (+6 -0)

📄 Description

A user reported a problem where the server sent no data (it sent an empty {} object). This results in the UI being "stuck" showing it synchronizing the banks forever.

This detects the issue of an empty object and throws a BankSync exception.

It also updates the SF batch sync code to properly handle if an exception happens, by setting every account to error status. I don't know if that is what we want, but it definitely reports an error and definitely stops it from being stuck.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3941 **Author:** [@psybers](https://github.com/psybers) **Created:** 12/8/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `sync_nodata` --- ### 📝 Commits (5) - [`ff39105`](https://github.com/actualbudget/actual/commit/ff39105148c8e40fb69e620c0975c0eb4a238c16) Fix issue where the UI is stuck sync'ing if no data from server - [`b502e4b`](https://github.com/actualbudget/actual/commit/b502e4b4c0bb2e6b4613906371404f0d85c1ecf6) add release note - [`2f4baf2`](https://github.com/actualbudget/actual/commit/2f4baf21c58dae8a0ae00f1bed889072c4933dd3) Merge branch 'master' into sync_nodata - [`c30edc7`](https://github.com/actualbudget/actual/commit/c30edc77f7428498f5ea8a9f2c26247669be8124) Merge branch 'master' into sync_nodata - [`8fbb13c`](https://github.com/actualbudget/actual/commit/8fbb13c6353152c7e260103c079c979bdb8c5b22) Merge branch 'master' into sync_nodata ### 📊 Changes **3 files changed** (+61 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.ts` (+3 -0) 📝 `packages/loot-core/src/server/main.ts` (+52 -36) ➕ `upcoming-release-notes/3941.md` (+6 -0) </details> ### 📄 Description A user reported a problem where the server sent no data (it sent an empty `{}` object). This results in the UI being "stuck" showing it synchronizing the banks forever. This detects the issue of an empty object and throws a `BankSync` exception. It also updates the SF batch sync code to properly handle if an exception happens, by setting every account to error status. I don't know if that is what we want, but it definitely reports an error and definitely stops it from being stuck. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5128
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?