mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-10 21:03:06 -05:00
[Bug]: [Mobile] Footer is not rendered in Add/Edit Transaction page #581
Closed
opened 2026-02-28 19:10:17 -06:00 by GiteaMirror
·
9 comments
No Branch/Tag Specified
master
enforce-append-only-migrations-ci
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
claude/error-codes-worker-boundary-26i5uu
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
ai/simplify-categories-get-api
api-browser-custom-data-dir
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#581
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joel-jeremy on GitHub (Aug 21, 2023).
Verified issue does not already exist?
What happened?
Footer is not rendered in Add/Edit Transaction page
What error did you receive?
N/A
Where are you hosting Actual?
Fly.io
What browsers are you seeing the problem on?
Chrome
Operating System
Mobile Device
@trevdor commented on GitHub (Aug 22, 2023):
Hey @joel-jeremy, I can see how that could feel off.
Not necessarily arguing it's best, but this is by design. It's a behavior ported from the original Actual native apps.
My assumption is it was meant to maximize screen real estate.
You either
< Backout of this screen or use theAdd/Save Transactionbutton.Similarly, we don't display the footer in the account ledger view.
@shall0pass commented on GitHub (Aug 30, 2023):
I was curious about this. I recorded the Android app screens for reference. Are you talking about the accounts page or the new 'add transaction' page? I was surprised to see the footer all the way through to the the account transaction listings page.
https://github.com/actualbudget/actual/assets/20625555/c0d6d60a-2097-47a4-9f21-14b64fa71080
@trevdor commented on GitHub (Sep 1, 2023):
Oh wow, I stand corrected! Sorry, @joel-jeremy for so confidently mis-remembering.
I only matched
MobileNavTabsto the screens that made sense to me at the time we added 'em:What do you guys think? Does it belong there? It certainly saves taps getting back to Budget view. On the other hand, it eats up screen real estate (looking out for us tiny phone guys...).
@shall0pass commented on GitHub (Sep 1, 2023):
Personally, I think it fits there. I did make a mental note that the bar in the RN app is about 1/2 the height as the Web app. Maybe small screens were a concern for James too?
I'm not sure why the + icon was on the accounts page though in the top right, unless he just wanted a visible button. Long pressing the account button on the bar was a shortcut to add a transaction in RN. I suppose adding the button didn't take up any vertical real estate since it was aligned with the account name. In our case, I think two + on the same screen that do the same thing feels redundant.
My 2¢.
@Kidglove57 commented on GitHub (Sep 1, 2023):
Just my view but I am happy with the status quo here as I cannot see a need or use for the footer in the "add transaction" or "edit transaction" dialogue screen. Once I have completed and exited from either of these tasks the footer becomes visible again (and I do not need it until then).
@trevdor commented on GitHub (Sep 1, 2023):
However, the fact I wasn't aware of it might be evidence it's not the most discoverable interaction. Wonder how that could be improved? Anyway, separate question from this thread's main topic.
@MatissJanis commented on GitHub (Sep 1, 2023):
Opened a separate issue to discuss the "crowdedness" of the footer: https://github.com/actualbudget/actual/issues/1633
@MatissJanis commented on GitHub (Sep 1, 2023):
One the root topic here:
Personally I think the footer should not be visible in the transaction entry page. Reason being: it's way too easy to mis-click on the bottom of the screen. Which in turn would mean losing all the inputs as the user is directed away from transaction entry.
But at the same time I'm not really a user for mobile-transaction entry, so take my opinion with a grain of salt :)
@shall0pass commented on GitHub (Sep 1, 2023):
I was under the mistaken impression that interactions like long press wouldn't be possible with a PWA, so that's cool.Is there something we could do to the icon to indicate a second function? Maybe adding a + above the account icon. Secondary actions could have a different color or a shadow to distinguish it. For that to make sense though, we might want to think about other secondary actions that could be implemented. One offs don't really set a trend for discovery.
</Side topic>
If we're discussing the newly added transaction edit screen, I don't really think that the footer belongs, if we're talking about the account ledger screen, I'm leaning towards it belonging. But I still find it plenty usable as is. Usually after I'm done in the accounts view I head back to the budget, and the footer would remove one button press.