github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #601] [MERGED] Improve handling of schedules that are missing a date #3202

New Issue
Closed
opened 2026-02-28 20:38:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:38:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/601
Author: @j-f1
Created: 1/30/2023
Status: ✅ Merged
Merged: 2/1/2023
Merged by: @j-f1

Base: master ← Head: jed/schedule-no-date

📝 Commits (4)

  • 8046523 Fix adding date back to a schedule that lost its date
  • 70f7a8a Propagate errors when searching matching transactions
  • 099cd11 Make the error more visible
  • d119f29 Block removing the date field on schedule-linked rules

📊 Changes

4 files changed (+36 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js (+2 -0)
📝 packages/desktop-client/src/components/modals/EditRule.js (+10 -1)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+22 -1)
📝 packages/loot-core/src/server/schedules/app.js (+2 -2)

📄 Description

Fixes #581. The underlying issue was removing the date.

  • handle errors from calling updateScheduleConditions and display them in the form
  • show “no transactions found” or the error in the transaction list if search results are empty
  • fix an error that happened when trying to save a schedule that had previously had its date removed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/601 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/30/2023 **Status:** ✅ Merged **Merged:** 2/1/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/schedule-no-date` --- ### 📝 Commits (4) - [`8046523`](https://github.com/actualbudget/actual/commit/8046523491f883bfc1c3d53ca506e8d519ba14da) Fix adding date back to a schedule that lost its date - [`70f7a8a`](https://github.com/actualbudget/actual/commit/70f7a8a290006731d144c3576ebae286c22a6b2c) Propagate errors when searching matching transactions - [`099cd11`](https://github.com/actualbudget/actual/commit/099cd114f09b795623e9d6a659d7e775b5c16238) Make the error more visible - [`d119f29`](https://github.com/actualbudget/actual/commit/d119f29dff0e47fa6ba9a72cd6fe1f8f67ec4c2b) Block removing the date field on schedule-linked rules ### 📊 Changes **4 files changed** (+36 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js` (+2 -0) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+10 -1) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+22 -1) 📝 `packages/loot-core/src/server/schedules/app.js` (+2 -2) </details> ### 📄 Description Fixes #581. The underlying issue was removing the date. - handle errors from calling `updateScheduleConditions` and display them in the form - show “no transactions found” or the error in the transaction list if search results are empty - fix an error that happened when trying to save a schedule that had previously had its date removed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:38:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3202
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?